On Mon, Mar 27, 2023 at 4:52 PM Peter Geoghegan wrote:
> This is fine, as far as it goes. Obviously it fixes the immediate problem.
OK, I've committed and back-patched this fix to v14, just like the
erroneous commit that created the issue.
--
Robert Haas
EDB: http://www.enterprisedb.com
On Mon, Mar 27, 2023 at 1:17 PM Robert Haas wrote:
> Patch attached.
This is fine, as far as it goes. Obviously it fixes the immediate problem.
> > I don't think that it's particularly likely that having refined
> > aborted speculative insertion amcheck coverage will make a critical
> > differen
On Mon, Mar 27, 2023 at 2:34 PM Peter Geoghegan wrote:
> > Since this was back-patched, I think it's probably better to just
> > remove the error. We can introduce new validation if we want, but that
> > should probably be master-only.
>
> That makes sense.
Patch attached.
> I don't think that i
On Mon, Mar 27, 2023 at 10:17 AM Robert Haas wrote:
> > What about aborted speculative insertions? See
> > heap_abort_speculative(), which directly sets the speculatively
> > inserted heap tuple's xmin to InvalidTransactionId/zero.
>
> Oh, dear. I didn't know about that case.
A big benefit of hav
On Sat, Mar 25, 2023 at 6:25 PM Peter Geoghegan wrote:
> On Fri, Mar 24, 2023 at 8:13 AM Robert Haas wrote:
> > If we're checking xmin and find that it is invalid (i.e. 0) just
> > report that as corruption, similar to what's already done in the
> > three cases that seem correct. If we're checkin
