Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-09-20 Thread Tom Lane
Peter Eisentraut writes: > It looks like there is documentation for PG_COLORS in the release notes > now, which seems like an odd place. Suggestions for a better place? BTW, as far as that goes, it looks like PG_COLOR is documented separately in each frontend program's "Environment" man page sec

Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-09-18 Thread Tom Lane
Peter Eisentraut writes: > On 2019-06-06 11:08, Masahiko Sawada wrote: >>> Do we need two variables to control this? I was only looking at >>> PG_COLOR, and noticed PG_COLORS only later. Keeping PG_COLORS aligned >>> with {GCC,LS}_COLORS makes sense. How about removing PG_COLOR, and >>> making "au

Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-09-18 Thread Peter Eisentraut
On 2019-06-06 11:08, Masahiko Sawada wrote: > On Tue, Apr 9, 2019 at 9:01 PM Christoph Berg wrote: >> >> Re: Peter Eisentraut 2019-04-09 >> >>> I'm okay with changing it. As you indicate, I chose the name so that it >>> doesn't look like a libpq variable. There are some other PG_ variables >>>

Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-06-06 Thread Masahiko Sawada
On Tue, Apr 9, 2019 at 9:01 PM Christoph Berg wrote: > > Re: Peter Eisentraut 2019-04-09 > > > I'm okay with changing it. As you indicate, I chose the name so that it > > doesn't look like a libpq variable. There are some other PG_ variables > > throughout the code, but those appear to be most

Re: pgsql: Unified logging system for command-line programs

2019-04-10 Thread Peter Eisentraut
On 2019-04-09 13:58, Christoph Berg wrote: > I'm not entirely sure what happened here, but I think this made > pg_restore verbose by default (and there is no --quiet option). That was by accident. Fixed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 S

Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-04-09 Thread Christoph Berg
Re: Peter Eisentraut 2019-04-09 > I'm okay with changing it. As you indicate, I chose the name so that it > doesn't look like a libpq variable. There are some other PG_ variables > throughout the code, but those appear to be mostly for internal use. > Also, there is GCC_COLORS, LS_COLORS, etc.

Re: pgsql: Unified logging system for command-line programs

2019-04-09 Thread Christoph Berg
Re: Peter Eisentraut 2019-04-01 > - There is support for setting a "log level". This is not meant to be > user-facing, but can be used internally to implement debug or > verbose modes. I'm not entirely sure what happened here, but I think this made pg_restore verbose by default (and there is

Re: PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-04-09 Thread Peter Eisentraut
On 2019-04-09 11:22, Christoph Berg wrote: > Can we rename PG_COLOR to PGCOLOR? This is the only PG* environment > variable prefixed with the extra underscore, and remembering that will > be confusing. (Like pgbench should really be named pg_bench for > consistency.) Even if it's not a libpq variab

PGCOLOR? (Re: pgsql: Unified logging system for command-line programs)

2019-04-09 Thread Christoph Berg
Re: Peter Eisentraut 2019-04-01 > - Some color in the messages, similar to gcc and clang. Set > PG_COLOR=auto to try it out. Some colors are predefined, but can be > customized by setting PG_COLORS. Can we rename PG_COLOR to PGCOLOR? This is the only PG* environment variable prefixed with t