Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

2019-07-20 Thread Michael Paquier
On Fri, Jul 19, 2019 at 02:56:34PM -0400, Tom Lane wrote: > I'm not quite convinced whether that will silence the warning, but > at least it's a bit less unreadable. Thanks for working with upstream on this. From what I can see, woodlouse & friends do not complain anymore. -- Michael signature.

Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

2019-07-19 Thread Tom Lane
I wrote: > Michael Paquier writes: >> This is causing a compilation warning on Windows: > ...so I think your compiler has a point. I shall complain to upstream. The IANA folk want to fix it like this: diff --git a/zic.c b/zic.c index 8bf5628..a84703a 100644 --- a/zic.c +++ b/zic.c @@ -2145,7 +2

Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

2019-07-18 Thread Tom Lane
Michael Paquier writes: > This is causing a compilation warning on Windows: > src/timezone/zic.c(2401): warning C4804: '-' : unsafe use of type > 'bool' in operation Hmmm ... the code looks like boollocut, hicut; ... thistimecnt = -locut -

Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

2019-07-18 Thread Michael Paquier
Hi Tom, (moving to -hackers) On Wed, Jul 17, 2019 at 10:26:45PM +, Tom Lane wrote: > Sync our copy of the timezone library with IANA release tzcode2019b. > > A large fraction of this diff is just due to upstream's somewhat > random decision to rename a bunch of internal variables and struct >