Re: pgsql: Refactor dlopen() support

2018-09-07 Thread Tom Lane
Peter Eisentraut writes: > On 07/09/2018 16:19, Tom Lane wrote: >> Somehow or other, the changes you made in dfmgr.c's #include lines >> have made it so that find_rendezvous_variable's local "bool found" >> variable is actually of type _Bool (which is word-wide on these >> machines). > Ah because

Re: pgsql: Refactor dlopen() support

2018-09-07 Thread Peter Eisentraut
On 07/09/2018 16:19, Tom Lane wrote: > Somehow or other, the changes you made in dfmgr.c's #include lines > have made it so that find_rendezvous_variable's local "bool found" > variable is actually of type _Bool (which is word-wide on these > machines). However, hash_search thinks its output varia

Re: pgsql: Refactor dlopen() support

2018-09-07 Thread Tom Lane
Peter Eisentraut writes: > On 07/09/2018 08:30, Tom Lane wrote: >> Buildfarm member locust doesn't like this much. I've been able to >> reproduce the problem on an old Mac laptop running the same macOS release, >> viz 10.5.8. (Note that we're not seeing it on earlier or later releases, >> which

Re: pgsql: Refactor dlopen() support

2018-09-07 Thread Peter Eisentraut
On 07/09/2018 08:30, Tom Lane wrote: > Peter Eisentraut writes: >> Refactor dlopen() support > > Buildfarm member locust doesn't like this much. I've been able to > reproduce the problem on an old Mac laptop running the same macOS release, > viz 10.5.8. (Note that we're not seeing it on earlier

Re: pgsql: Refactor dlopen() support

2018-09-06 Thread Tom Lane
Peter Eisentraut writes: > Refactor dlopen() support Buildfarm member locust doesn't like this much. I've been able to reproduce the problem on an old Mac laptop running the same macOS release, viz 10.5.8. (Note that we're not seeing it on earlier or later releases, which is odd in itself.) Ac