Re: pgsql: Move snowball_create.sql creation into perl file

2023-05-23 Thread Tom Lane
[ dropping -packagers ] Andres Freund writes: > I guess I need to go and check how long the "release" tarball generation > takes... It's quick except for the documentation-generating steps. Maybe we could test that part only once? regards, tom lane

Re: pgsql: Move snowball_create.sql creation into perl file

2023-05-23 Thread Andres Freund
Hi, On 2023-05-23 10:46:30 -0400, Tom Lane wrote: > Christoph Berg writes: > >> this seems to have broken out-of-tree builds from tarballs: > >> > >> /usr/bin/install -c -m 644 snowball_create.sql > >> '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16' > >> /usr/bin/

Re: pgsql: Move snowball_create.sql creation into perl file

2023-05-23 Thread Christoph Berg
Re: Tom Lane > I think the attached will do for a proper fix. I'm not inclined > to re-wrap just for this. Sure, I just posted it here in case others run into the same problem. Thanks! Christoph

Re: pgsql: Move snowball_create.sql creation into perl file

2023-05-23 Thread Tom Lane
Christoph Berg writes: >> this seems to have broken out-of-tree builds from tarballs: >> >> /usr/bin/install -c -m 644 snowball_create.sql >> '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16' >> /usr/bin/install: cannot stat 'snowball_create.sql': No such file or >>

Re: pgsql: Move snowball_create.sql creation into perl file

2023-05-23 Thread Christoph Berg
Re: To Andres Freund > this seems to have broken out-of-tree builds from tarballs: > > /usr/bin/install -c -m 644 snowball_create.sql > '/srv/projects/postgresql/debian/16/build/tmp_install/usr/share/postgresql/16' > /usr/bin/install: cannot stat 'snowball_create.sql': No such file or directory

Re: pgsql: Move snowball_create.sql creation into perl file

2023-05-23 Thread Christoph Berg
Re: Andres Freund > Move snowball_create.sql creation into perl file > > This is in preparation for building postgres with meson / ninja. > > We already have duplicated code for this between the make and msvc > builds. Adding a third copy seems like a bad plan, thus move the generation > into a p