Re: pgsql: Introduce hash_search_with_hash_value() function

2024-08-23 Thread Robert Haas
On Thu, Aug 15, 2024 at 5:02 PM Nathan Bossart wrote: > On Wed, Aug 07, 2024 at 02:01:30PM -0400, Robert Haas wrote: > > Also, for the notes to be useful, we'd probably need some conventions > > about how we, as a project, want to use them. If everyone does > > something different, the result isn'

Re: pgsql: Introduce hash_search_with_hash_value() function

2024-08-15 Thread Nathan Bossart
On Wed, Aug 07, 2024 at 02:01:30PM -0400, Robert Haas wrote: > Also, for the notes to be useful, we'd probably need some conventions > about how we, as a project, want to use them. If everyone does > something different, the result isn't likely to be all that great. What did you have in mind? Wou

Re: pgsql: Introduce hash_search_with_hash_value() function

2024-08-07 Thread Alexander Korotkov
On Wed, Aug 7, 2024 at 9:01 PM Robert Haas wrote: > On Wed, Aug 7, 2024 at 1:15 PM Nathan Bossart > wrote: > > > We could use git notes. The UI is a bit inconvenient (they have to be > > > pushed and pulled separately from commits), but they seem useful enough. > > > > Yeah, I spend a lot of ti

Re: pgsql: Introduce hash_search_with_hash_value() function

2024-08-07 Thread Robert Haas
On Wed, Aug 7, 2024 at 1:15 PM Nathan Bossart wrote: > > We could use git notes. The UI is a bit inconvenient (they have to be > > pushed and pulled separately from commits), but they seem useful enough. > > Yeah, I spend a lot of time on commit messages because they're pretty much > written in s

Re: pgsql: Introduce hash_search_with_hash_value() function

2024-08-07 Thread Nathan Bossart
On Wed, Aug 07, 2024 at 01:08:35PM -0400, Alvaro Herrera wrote: > On 2024-Aug-07, Robert Haas wrote: >> I really wish there was some way to fix commit messages. I had a typo >> in mine today, too. > > We could use git notes. The UI is a bit inconvenient (they have to be > pushed and pulled separa

Re: pgsql: Introduce hash_search_with_hash_value() function

2024-08-07 Thread Alvaro Herrera
On 2024-Aug-07, Robert Haas wrote: > I really wish there was some way to fix commit messages. I had a typo > in mine today, too. We could use git notes. The UI is a bit inconvenient (they have to be pushed and pulled separately from commits), but they seem useful enough. https://initialcommit.c