Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Stephen Frost
Greetings, On Tue, Nov 16, 2021 at 15:12 Tom Lane wrote: > Alvaro Herrera writes: > > On 2021-Nov-16, Stephen Frost wrote: > >> Not against possibly changing that but I don’t get the point of > including > >> be-gssapi-common.h if it’s not enabled in the build and typically if > GSSAPI > >> is

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Tom Lane
Alvaro Herrera writes: > On 2021-Nov-16, Stephen Frost wrote: >> Not against possibly changing that but I don’t get the point of including >> be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI >> is possible and the reason for including be-gssapi-common.h then there’s >> o

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Stephen Frost
Greetings, On Tue, Nov 16, 2021 at 13:16 Alvaro Herrera wrote: > On 2021-Nov-16, Stephen Frost wrote: > > > Not against possibly changing that but I don’t get the point of including > > be-gssapi-common.h if it’s not enabled in the build and typically if > GSSAPI > > is possible and the reason f

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Alvaro Herrera
On 2021-Nov-16, Stephen Frost wrote: > Not against possibly changing that but I don’t get the point of including > be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI > is possible and the reason for including be-gssapi-common.h then there’s > other things that need to be u

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Alvaro Herrera
On 2021-Nov-16, Stephen Frost wrote: > I’ve not looked at this very closely but no, normally it’s the inclusion of > be-gssapi-common.h that’s wrapped in the ifdef, not the contents of it, > again, see auth.c I don't think you read my original post very carefully. I'm talking about sanitizing th

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Stephen Frost
Greetings, On Tue, Nov 16, 2021 at 12:33 Alvaro Herrera wrote: > On 2021-Nov-16, Stephen Frost wrote: > > > Short answer is yes, inclusion of be-gssapi-common.h is typically > > wrapped in a #ifdef, see src/backend/libpq/auth.c > > It'd be as in the attached, then. I’ve not looked at this very

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Alvaro Herrera
On 2021-Nov-16, Stephen Frost wrote: > Short answer is yes, inclusion of be-gssapi-common.h is typically > wrapped in a #ifdef, see src/backend/libpq/auth.c It'd be as in the attached, then. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ >From db4a303a8a7c0c142

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > On 2021-Nov-16, Alvaro Herrera wrote: > > > Fix headerscheck failure in replication/worker_internal.h > > The other failure is in src/include/libpq/be-gssapi-common.h: > > In file included from /tmp/headerscheck.a6f0um/test.c:2: > .

Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

2021-11-16 Thread Alvaro Herrera
On 2021-Nov-16, Alvaro Herrera wrote: > Fix headerscheck failure in replication/worker_internal.h The other failure is in src/include/libpq/be-gssapi-common.h: In file included from /tmp/headerscheck.a6f0um/test.c:2: ./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.h: No