Re: pgsql: Fix and document lock handling for in-memory replication slot da

2018-06-11 Thread Michael Paquier
On Mon, Jun 11, 2018 at 09:49:52AM -0700, Andres Freund wrote: > Same is true for the codepaths calling GetRedoRecPtr(). You are right. I'll fix in a minute. A first commit's stress make things really harder to get right... > I don't object to the general idea of adding locking - although the >

Re: pgsql: Fix and document lock handling for in-memory replication slot da

2018-06-11 Thread Andres Freund
Hi, On 2018-06-10 10:45:04 +, Michael Paquier wrote: > Fix and document lock handling for in-memory replication slot data > > While debugging issues on HEAD for the new slot forwarding feature of > Postgres 11, some monitoring of the code surrounding in-memory slot data > has proved that the l

Re: pgsql: Fix and document lock handling for in-memory replication slot da

2018-06-10 Thread Michael Paquier
On Sun, Jun 10, 2018 at 10:45:04AM +, Michael Paquier wrote: > Fix and document lock handling for in-memory replication slot data > > [... snip ...] > > Details > --- > https://git.postgresql.org/pg/commitdiff/9e149c847f398793ec1641885434dcd10837d89d My apologies here. This commit has a