Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8

2022-07-04 Thread Peter Eisentraut
On 04.07.22 19:32, Tom Lane wrote: If the result of IDENTIFY_SYSTEM is always sent in text format, then I agree that this isn't very problematic. If there are any clients that fetch it in binary mode, though, this is absolutely a wire protocol break for them The result rows of the replication

Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8

2022-07-04 Thread Tom Lane
Peter Eisentraut writes: > On 04.07.22 07:55, Tom Lane wrote: >> But what about whatever code is reading the output? And what if >> that code isn't v16? I can't believe that we can make a wire >> protocol change as summarily as this. > I think a client will either just read the string value and

Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8

2022-07-04 Thread Peter Eisentraut
On 04.07.22 07:55, Tom Lane wrote: Peter Eisentraut writes: Change timeline field of IDENTIFY_SYSTEM to int8 Surely this patch is far from complete? To start with, just a few lines down in IdentifySystem() the column is filled using Int32GetDatum not Int64GetDatum. I will get some popcorn