Re: pgsql: Avoid using ambiguous word "positive" in error message.

2021-08-31 Thread Andrew Dunstan
On 8/30/21 10:19 AM, Robert Haas wrote: > On Mon, Aug 30, 2021 at 10:16 AM Tom Lane wrote: >> Robert Haas writes: >>> The new style seems good, but I don't really agree that "positive" and >>> "non-negative" are ambiguous. "positive" means >0 and "non-negative" >>> means >= 0, because 0 is neit

Re: pgsql: Avoid using ambiguous word "positive" in error message.

2021-08-30 Thread Robert Haas
On Mon, Aug 30, 2021 at 10:16 AM Tom Lane wrote: > Robert Haas writes: > > The new style seems good, but I don't really agree that "positive" and > > "non-negative" are ambiguous. "positive" means >0 and "non-negative" > > means >= 0, because 0 is neither positive nor negative. > > Well, the poin

Re: pgsql: Avoid using ambiguous word "positive" in error message.

2021-08-30 Thread Tom Lane
Robert Haas writes: > The new style seems good, but I don't really agree that "positive" and > "non-negative" are ambiguous. "positive" means >0 and "non-negative" > means >= 0, because 0 is neither positive nor negative. Well, the point is precisely that not everyone makes that distinction. I ag

Re: pgsql: Avoid using ambiguous word "positive" in error message.

2021-08-30 Thread Robert Haas
On Tue, Aug 24, 2021 at 10:49 PM Fujii Masao wrote: > Avoid using ambiguous word "positive" in error message. The new style seems good, but I don't really agree that "positive" and "non-negative" are ambiguous. "positive" means >0 and "non-negative" means >= 0, because 0 is neither positive nor n