Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-25 Thread Andrew Dunstan
On 2022-04-24 Su 15:37, Andrew Dunstan wrote: > On 2022-04-24 Su 14:19, Noah Misch wrote: > >> Even if MinGW has >> some magic to make that work, I suspect we'll want a non-header home. >> Perhaps >> src/common/exec.c? It's best to keep this symbol out of libpq and other >> DLLs, though I bet

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-24 Thread Andrew Dunstan
On 2022-04-24 Su 14:19, Noah Misch wrote: > On Sun, Apr 24, 2022 at 01:09:08PM -0400, Andrew Dunstan wrote: >> On 2022-04-22 Fr 22:59, Noah Misch wrote: >>> The MinGW gcc crt*.o files do shell-glob expansion on the arguments before >>> entering main(). See https://google.com/search?q=mingw+comma

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-24 Thread Noah Misch
On Sun, Apr 24, 2022 at 01:09:08PM -0400, Andrew Dunstan wrote: > On 2022-04-22 Fr 22:59, Noah Misch wrote: > > The MinGW gcc crt*.o files do shell-glob expansion on the arguments before > > entering main(). See https://google.com/search?q=mingw+command+line+glob > > for > > various discussion of

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-24 Thread Andrew Dunstan
On 2022-04-22 Fr 22:59, Noah Misch wrote: > On Sat, Apr 23, 2022 at 09:12:20AM +1200, Thomas Munro wrote: >> On Sat, Apr 23, 2022 at 8:06 AM Robert Haas wrote: >>> I have to say the fact that IPC::Run does shell-glob expansion of its >>> arguments on some machines and not others seems ludicrous

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-22 Thread Noah Misch
On Sat, Apr 23, 2022 at 09:12:20AM +1200, Thomas Munro wrote: > On Sat, Apr 23, 2022 at 8:06 AM Robert Haas wrote: > > I have to say the fact that IPC::Run does shell-glob expansion of its > > arguments on some machines and not others seems ludicrous to me. This > > patch may be overtested, but su

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-22 Thread Thomas Munro
On Sat, Apr 23, 2022 at 8:06 AM Robert Haas wrote: > Sure, see also > http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2h0hzluphqsy6vc8ba7...@mail.gmail.com > where Andrew's opinion on how to fix this was sought. > > I have to say the fact that IPC::Run does shell-glob expansion of its > arguments

Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

2022-04-22 Thread Robert Haas
On Fri, Apr 22, 2022 at 10:24 AM Andrew Dunstan wrote: > On 2022-04-22 Fr 10:04, Tom Lane wrote: > > Andrew Dunstan writes: > >> This has upset the buildfarm's msys2 animals. There appears to be some > >> wildcard expansion going on that causes the problem. I don't know why it > >> should here wh