Re: pgbench with partitioned tables

2025-02-11 Thread Melanie Plageman
On Tue, Feb 11, 2025 at 2:29 PM Melanie Plageman wrote: > > I was testing with this with the intent to commit it and noticed that > it does change behavior in one way -- previously if you created an > unlogged table with the same schema as one of the pgbench tables and > then used client-side data

Re: pgbench with partitioned tables

2025-02-11 Thread Melanie Plageman
On Tue, Feb 11, 2025 at 2:29 PM Melanie Plageman wrote: > > On Tue, Feb 11, 2025 at 3:10 AM Sergey Tatarintsev > wrote: > > > > 08.02.2025 17:32, Álvaro Herrera пишет: > > > On 2025-Feb-07, Melanie Plageman wrote: > > > > > >> Okay, I've stared at this a bit, and it seems basically fine the way >

Re: pgbench with partitioned tables

2025-02-11 Thread Melanie Plageman
On Tue, Feb 11, 2025 at 3:10 AM Sergey Tatarintsev wrote: > > 08.02.2025 17:32, Álvaro Herrera пишет: > > On 2025-Feb-07, Melanie Plageman wrote: > > > >> Okay, I've stared at this a bit, and it seems basically fine the way > >> it is (I might add a bit more whitespace, clean up the commit message

Re: pgbench with partitioned tables

2025-02-11 Thread Sergey Tatarintsev
08.02.2025 17:32, Álvaro Herrera пишет: On 2025-Feb-07, Melanie Plageman wrote: Okay, I've stared at this a bit, and it seems basically fine the way it is (I might add a bit more whitespace, clean up the commit message, etc). So I'm interested in committing it. I will admit that having never co

Re: pgbench with partitioned tables

2025-02-08 Thread Álvaro Herrera
On 2025-Feb-07, Melanie Plageman wrote: > Okay, I've stared at this a bit, and it seems basically fine the way > it is (I might add a bit more whitespace, clean up the commit message, > etc). So I'm interested in committing it. I will admit that having > never committed anything to pgbench, I'm a

Re: pgbench with partitioned tables

2025-02-07 Thread Melanie Plageman
On Mon, Feb 3, 2025 at 7:23 AM Sergey Tatarintsev wrote: > > 03.02.2025 14:57, Álvaro Herrera пишет: > > On 2025-Feb-03, Sergey Tatarintsev wrote: > > > >> Thanks for the note. I changed the query in the patch (v2 patch attached) > >> > >> Btw, an additional benefit from the patch is that we can u

Re: pgbench with partitioned tables

2025-02-03 Thread Sergey Tatarintsev
03.02.2025 14:57, Álvaro Herrera пишет: On 2025-Feb-03, Sergey Tatarintsev wrote: Thanks for the note. I changed the query in the patch (v2 patch attached) Btw, an additional benefit from the patch is that we can use foreign tables (for example, to test postgres_fdw optimizations) Good though

Re: pgbench with partitioned tables

2025-02-02 Thread Álvaro Herrera
On 2025-Feb-03, Sergey Tatarintsev wrote: > Thanks for the note. I changed the query in the patch (v2 patch attached) > > Btw, an additional benefit from the patch is that we can use foreign tables > (for example, to test postgres_fdw optimizations) Good thought, and maybe it would be better if

Re: pgbench with partitioned tables

2025-02-02 Thread Sergey Tatarintsev
02.02.2025 20:45, Álvaro Herrera пишет: On 2025-Jan-31, Melanie Plageman wrote: Maybe instead of just not using COPY FREEZE on a table if it is partitioned, we could add new data generation init_steps. Perhaps one that is client-side data generation (g) but with no freezing? I'm not really sur

Re: pgbench with partitioned tables

2025-02-02 Thread Sami Imseih
I was looking at the comments [1] for why COPY FREEZE is not allowed on a parent table, and it was mainly due to having to open up partitions to check if they are able to take the optimization (table created or truncated in the current transaction ). Obviously as the number of partitions grow, it w

Re: pgbench with partitioned tables

2025-02-02 Thread Álvaro Herrera
On 2025-Jan-31, Melanie Plageman wrote: > Maybe instead of just not using COPY FREEZE on a table if it is > partitioned, we could add new data generation init_steps. Perhaps one > that is client-side data generation (g) but with no freezing? I'm not > really sure what the letter would be (f? makin

Re: pgbench with partitioned tables

2025-01-31 Thread Sami Imseih
> > IMO, If there is a good reason to allow the other pgbench > > tables to be partitioned, that may be better to think > > about. I am not sure there is though. > > see this thread [1] proposing partitioning pgbench_history last year. > > [1] > https://www.postgresql.org/message-id/flat/CAAKRu_Zo

Re: pgbench with partitioned tables

2025-01-31 Thread Melanie Plageman
On Fri, Jan 31, 2025 at 6:32 AM Sergey Tatarintsev wrote: > > When using manually created partitioned tables for pgbench, an error > occurred: > ERROR: cannot perform COPY FREEZE on a partitioned table. > > Currently only pgbench_accounts can be partitioned, all others must be a > regular tables.

Re: pgbench with partitioned tables

2025-01-31 Thread Melanie Plageman
On Fri, Jan 31, 2025 at 2:27 PM Sami Imseih wrote: > > pgbench_accounts is the only table that should grow to > the point where partitioning can benefit the tpcb-like > benchmark. pgbench_history is append-only, so I could see the argument for partitioning that. > IMO, If there is a good reason

Re: pgbench with partitioned tables

2025-01-31 Thread Sami Imseih
pgbench_accounts is the only table that should grow to the point where partitioning can benefit the tpcb-like benchmark. It looks like you have customized the pgbench schema that partitions the other pgbench tables, so you can use a custom script to initialize the data. IMO, If there is a good re

pgbench with partitioned tables

2025-01-31 Thread Sergey Tatarintsev
Hello, hackers! When using manually created partitioned tables for pgbench, an error occurred: ERROR:  cannot perform COPY FREEZE on a partitioned table. Currently only pgbench_accounts can be partitioned, all others must be a regular tables. I wrote a patch to disable WITH (FREEZE = ON) wh