Re: pgbench calculates summary numbers a wrong way.

2020-09-18 Thread Kyotaro Horiguchi
At Fri, 18 Sep 2020 17:28:22 +0900 (JST), Kyotaro Horiguchi wrote in > > I have submitted a patch which reworks how things are computed so that > > performance figures make some/more sense, among other things. > > > > Maybe you could have a look at it and tell whether it is an > > improvement w

Re: pgbench calculates summary numbers a wrong way.

2020-09-18 Thread Kyotaro Horiguchi
At Fri, 18 Sep 2020 09:55:30 +0200 (CEST), Fabien COELHO wrote in > > Hello, > > >> Sorry, I sent a wrong version of the patch, contains some spelling > >> errors. This is the right one. > > > > Sigh.. I fixed some more wordings. > > I have submitted a patch which reworks how things are compu

Re: pgbench calculates summary numbers a wrong way.

2020-09-18 Thread Kyotaro Horiguchi
At Thu, 17 Sep 2020 17:59:45 +0900 (JST), Kyotaro Horiguchi wrote in > Sigh.. I fixed some more wordings. The condition "all clients took the same time to establish a connection" is not needed for the transformation, and an intermediate expression was wrong. Fixed them. regards. -- Kyotaro H

Re: pgbench calculates summary numbers a wrong way.

2020-09-18 Thread Fabien COELHO
Hello, Sorry, I sent a wrong version of the patch, contains some spelling errors. This is the right one. Sigh.. I fixed some more wordings. I have submitted a patch which reworks how things are computed so that performance figures make some/more sense, among other things. Maybe you coul

Re: pgbench calculates summary numbers a wrong way.

2020-09-17 Thread Kyotaro Horiguchi
At Thu, 17 Sep 2020 17:52:23 +0900 (JST), Kyotaro Horiguchi wrote in > Sorry, I sent a wrong version of the patch, contains some spelling > errors. This is the right one. Sigh.. I fixed some more wordings. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From bd41d38cb056a6b8fe

Re: pgbench calculates summary numbers a wrong way.

2020-09-17 Thread Kyotaro Horiguchi
Mmm.. At Thu, 17 Sep 2020 17:41:54 +0900 (JST), Kyotaro Horiguchi wrote in > While running pgbench, I found tps excluding connection somewhat > strange. To emphasize the behavior, I inserted some sleep at the end > of doConnect() and ran pgbench with several times. Sorry, I sent a wrong versi

pgbench calculates summary numbers a wrong way.

2020-09-17 Thread Kyotaro Horiguchi
Hello. While running pgbench, I found tps excluding connection somewhat strange. To emphasize the behavior, I inserted some sleep at the end of doConnect() and ran pgbench with several times. $ pgbench -T 5 -j 1 -c 4 (with 1s sleep in doConnect()) > number of transactions actually processed: 4