Re: pgbench --partitions=0

2022-05-17 Thread Amit Langote
On Wed, May 18, 2022 at 9:50 Michael Paquier wrote: > On Mon, May 16, 2022 at 03:00:51PM +0900, Michael Paquier wrote: > > (I have added an open item, just in case.) > > And fixed as of 27f1366 Thank you. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com

Re: pgbench --partitions=0

2022-05-17 Thread Michael Paquier
On Mon, May 16, 2022 at 03:00:51PM +0900, Michael Paquier wrote: > (I have added an open item, just in case.) And fixed as of 27f1366. -- Michael signature.asc Description: PGP signature

Re: pgbench --partitions=0

2022-05-15 Thread Michael Paquier
On Mon, May 16, 2022 at 02:44:47PM +0900, Amit Langote wrote: > Sounds good to me. (I have added an open item, just in case.) -- Michael signature.asc Description: PGP signature

Re: pgbench --partitions=0

2022-05-15 Thread Amit Langote
On Mon, May 16, 2022 at 2:41 PM Michael Paquier wrote: > On Mon, May 16, 2022 at 11:34:41AM +0900, Amit Langote wrote: > > Attached a patch to fix with a test added. cc'ing Michael who > > authored that commit. > > Indeed, 6f164e6d got that incorrectly. I don't really want to play > with the mas

Re: pgbench --partitions=0

2022-05-15 Thread Michael Paquier
On Mon, May 16, 2022 at 11:34:41AM +0900, Amit Langote wrote: > Attached a patch to fix with a test added. cc'ing Michael who > authored that commit. Indeed, 6f164e6d got that incorrectly. I don't really want to play with the master branch at this stage, even if this is trivial, but I'll fix it

pgbench --partitions=0

2022-05-15 Thread Amit Langote
Hi, I noticed that $subject causes an error in HEAD: $ pgbench -i --partitions=0 pgbench: error: --partitions must be in range 1..2147483647 However, it works in v13 and v14, assuming no partitions. I think the commit 6f164e6d17 may have unintentionally broken it, by introducing this hunk: @@