Re: pgbench: Improve result outputs related to failed transactinos

2024-10-24 Thread Tatsuo Ishii
Hello Alexander, > Hello Tatsuo-san, > > 11.10.2024 07:54, Tatsuo Ishii wrote: > ... > - number of transactions actually pocessed: 1 (tps = 410.846343) > ... >> Patch pushed. > > Please consider fixing a typo sneaked in that commit: pocessed -> > processed? Thank you for the repor

Re: pgbench: Improve result outputs related to failed transactinos

2024-10-24 Thread Alexander Lakhin
Hello Tatsuo-san, 11.10.2024 07:54, Tatsuo Ishii wrote: ... - number of transactions actually pocessed: 1 (tps = 410.846343) ... Patch pushed. Please consider fixing a typo sneaked in that commit: pocessed -> processed? Best regards, Alexander

Re: pgbench: Improve result outputs related to failed transactinos

2024-10-11 Thread Yugo NAGATA
On Fri, 11 Oct 2024 13:54:54 +0900 (JST) Tatsuo Ishii wrote: > >>> Thanks for the fix. Here is the new run with the v2 patch. The result > >>> looks good to me. > >>> > >>> src/bin/pgbench/pgbench -p 11002 -c1 -t 1 -f c.sql -f d.sql > >>> --failures-detailed -r test > >>> pgbench (18devel) > >

Re: pgbench: Improve result outputs related to failed transactinos

2024-10-10 Thread Tatsuo Ishii
>>> Thanks for the fix. Here is the new run with the v2 patch. The result >>> looks good to me. >>> >>> src/bin/pgbench/pgbench -p 11002 -c1 -t 1 -f c.sql -f d.sql >>> --failures-detailed -r test >>> pgbench (18devel) >>> starting vacuum...end. >>> transaction type: multiple scripts >>> scaling

Re: pgbench: Improve result outputs related to failed transactinos

2024-10-08 Thread Tatsuo Ishii
>> > I overlooked the "NaN% of total" in per-script results. >> > I think this NaN also should be avoided. >> > >> > I fixed the number of transactions in per-script results to include >> > skipped and failed transactions. It prevents to print "total of NaN%" >> > when any transactions are not s

Re: pgbench: Improve result outputs related to failed transactinos

2024-09-24 Thread Yugo NAGATA
On Tue, 24 Sep 2024 19:00:04 +0900 (JST) Tatsuo Ishii wrote: > > I overlooked the "NaN% of total" in per-script results. > > I think this NaN also should be avoided. > > > > I fixed the number of transactions in per-script results to include > > skipped and failed transactions. It prevents to p

Re: pgbench: Improve result outputs related to failed transactinos

2024-09-24 Thread Tatsuo Ishii
> I overlooked the "NaN% of total" in per-script results. > I think this NaN also should be avoided. > > I fixed the number of transactions in per-script results to include > skipped and failed transactions. It prevents to print "total of NaN%" > when any transactions are not successfully proce

Re: pgbench: Improve result outputs related to failed transactinos

2024-09-23 Thread Yugo NAGATA
On Sun, 22 Sep 2024 17:59:34 +0900 (JST) Tatsuo Ishii wrote: > > I would like to improve the following two points on the result outputs > > of pgbench related to faild transaction. The patch is attached. > > > > (1) Output per-script statistics even when there are no successful > > transaction i

Re: pgbench: Improve result outputs related to failed transactinos

2024-09-22 Thread Tatsuo Ishii
Hi, > Hi, > > I would like to improve the following two points on the result outputs > of pgbench related to faild transaction. The patch is attached. > > (1) Output per-script statistics even when there are no successful > transaction if there is any failed transactions due to serialization > o

pgbench: Improve result outputs related to failed transactinos

2024-09-20 Thread Yugo Nagata
Subject: [PATCH] pgbench: Improve result outputs related to failed transactinos Previously, per-script statistics were never output when all transactions are failed due to serialization or deadlock errors. However, it is reasonable to report such information if there are ones even when there are no s