On Mon, Sep 3, 2018 at 10:06 PM, Yugo Nagata wrote:
> Hi,
>
> On Sat, 1 Sep 2018 07:40:40 +0200 (CEST)
> Fabien COELHO wrote:
>
>> > Attached is a patch to allow pg_verity_checksums to specify a database
>> > to scan. This is usefule for users who want to verify checksums of
>> > relations
>> >
Hello Yugo-san,
I attached the rebased patch.
Patch applies cleanly, compiles, "make check" is okay, although there are
no specific test for the feature. Indeed, after investigation there is not
a SINGLE test for the command:-(
I think that some minimal tap-testing should be done. It see
Hi,
On Sat, 1 Sep 2018 07:40:40 +0200 (CEST)
Fabien COELHO wrote:
> > Attached is a patch to allow pg_verity_checksums to specify a database
> > to scan. This is usefule for users who want to verify checksums of
> > relations
> > in a specific database. We can specify a database by OID using -
Hello Yugo-san,
Attached is a patch to allow pg_verity_checksums to specify a database
to scan. This is usefule for users who want to verify checksums of relations
in a specific database. We can specify a database by OID using -d or --dboid
option.
Also, when -g or --global-only is used only
On Mon, 27 Aug 2018 21:05:33 +0900
Yugo Nagata wrote:
> On Mon, 27 Aug 2018 13:34:12 +0200
> Michael Banck wrote:
>
> > Hi,
> >
> > On Mon, Aug 27, 2018 at 07:53:36PM +0900, Yugo Nagata wrote:
> > > On Fri, 24 Aug 2018 18:01:09 +0200
> > > Peter Eisentraut wrote:
> > > > I'm curious about thi
On Thu, 30 Aug 2018 07:18:13 -0300
Alvaro Herrera wrote:
> On 2018-Aug-30, Yugo Nagata wrote:
>
> > On Thu, 30 Aug 2018 06:52:58 -0300
> > Alvaro Herrera wrote:
>
> > > This should have been listed in the pg11 open items. Please list there
> > > everything that should apply be applied branch
On 2018-Aug-30, Yugo Nagata wrote:
> On Thu, 30 Aug 2018 06:52:58 -0300
> Alvaro Herrera wrote:
> > This should have been listed in the pg11 open items. Please list there
> > everything that should apply be applied branch 11 before release, so
> > that they get fixed (or at least considered) be
On Thu, 30 Aug 2018 06:52:58 -0300
Alvaro Herrera wrote:
> Thanks! Pushed. There was a markup error in the documentation.
Thank you!
>
>
> This should have been listed in the pg11 open items. Please list there
> everything that should apply be applied branch 11 before release, so
> that the
Thanks! Pushed. There was a markup error in the documentation.
This should have been listed in the pg11 open items. Please list there
everything that should apply be applied branch 11 before release, so
that they get fixed (or at least considered) before we release.
https://wiki.postgresql.org
On Thu, 30 Aug 2018 10:54:08 +0200
Michael Banck wrote:
> Hi,
>
> On Thu, Aug 30, 2018 at 05:48:24PM +0900, Yugo Nagata wrote:
> > Oops, It's my mistake. I updated the patch.
>
> Looks good to me now.
>
> One could argue that the message could be 'checksums verified in file
> FILE' (plural) ra
Hi,
On Thu, Aug 30, 2018 at 05:48:24PM +0900, Yugo Nagata wrote:
> Oops, It's my mistake. I updated the patch.
Looks good to me now.
One could argue that the message could be 'checksums verified in file
FILE' (plural) rather than 'checksum verified in file FILE', but that is
quickly approaching
On Thu, 30 Aug 2018 10:34:06 +0200
Michael Banck wrote:
> Hi,
>
> On Thu, Aug 30, 2018 at 05:35:09PM +0900, Yugo Nagata wrote:
> > --- a/doc/src/sgml/ref/pg_verify_checksums.sgml
> > +++ b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > @@ -61,11 +61,11 @@ PostgreSQL documentation
> >
> >
Hi,
On Thu, Aug 30, 2018 at 05:35:09PM +0900, Yugo Nagata wrote:
> --- a/doc/src/sgml/ref/pg_verify_checksums.sgml
> +++ b/doc/src/sgml/ref/pg_verify_checksums.sgml
> @@ -61,11 +61,11 @@ PostgreSQL documentation
>
>
>
> - -d
> + -v
Sorry that I did not catch this the fir
On Thu, 30 Aug 2018 10:13:31 +0200
Michael Banck wrote:
> Hi,
>
> thanks for fixing this up!
>
> On Wed, Aug 29, 2018 at 11:25:28PM +0900, Yugo Nagata wrote:
> > diff --git a/doc/src/sgml/ref/pg_verify_checksums.sgml
> > b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > index ecc5501eae..a1ff060
Hi,
thanks for fixing this up!
On Wed, Aug 29, 2018 at 11:25:28PM +0900, Yugo Nagata wrote:
> diff --git a/doc/src/sgml/ref/pg_verify_checksums.sgml
> b/doc/src/sgml/ref/pg_verify_checksums.sgml
> index ecc5501eae..a1ff060c2b 100644
> --- a/doc/src/sgml/ref/pg_verify_checksums.sgml
> +++ b/doc/s
On Wed, 29 Aug 2018 21:09:03 +0900
Yugo Nagata wrote:
> On Wed, 29 Aug 2018 13:46:38 +0200
> Magnus Hagander wrote:
>
> > On Wed, Aug 29, 2018 at 1:37 PM, Michael Banck
> > wrote:
> >
> > > Hi,
> > >
> > > On Wed, Aug 29, 2018 at 08:33:43PM +0900, Yugo Nagata wrote:
> > > > On Wed, 29 Aug 201
On Wed, 29 Aug 2018 13:46:38 +0200
Magnus Hagander wrote:
> On Wed, Aug 29, 2018 at 1:37 PM, Michael Banck
> wrote:
>
> > Hi,
> >
> > On Wed, Aug 29, 2018 at 08:33:43PM +0900, Yugo Nagata wrote:
> > > On Wed, 29 Aug 2018 10:28:33 +0200
> > > Daniel Gustafsson wrote:
> > > > > On 27 Aug 2018, a
On Wed, Aug 29, 2018 at 1:37 PM, Michael Banck
wrote:
> Hi,
>
> On Wed, Aug 29, 2018 at 08:33:43PM +0900, Yugo Nagata wrote:
> > On Wed, 29 Aug 2018 10:28:33 +0200
> > Daniel Gustafsson wrote:
> > > > On 27 Aug 2018, at 14:05, Yugo Nagata wrote:
> > > > On Mon, 27 Aug 2018 13:34:12 +0200
> > >
Hi,
On Wed, Aug 29, 2018 at 08:33:43PM +0900, Yugo Nagata wrote:
> On Wed, 29 Aug 2018 10:28:33 +0200
> Daniel Gustafsson wrote:
> > > On 27 Aug 2018, at 14:05, Yugo Nagata wrote:
> > > On Mon, 27 Aug 2018 13:34:12 +0200
> > > Michael Banck wrote:
> > >> On Mon, Aug 27, 2018 at 07:53:36PM +0900
On Wed, 29 Aug 2018 10:28:33 +0200
Daniel Gustafsson wrote:
> > On 27 Aug 2018, at 14:05, Yugo Nagata wrote:
> >
> > On Mon, 27 Aug 2018 13:34:12 +0200
> > Michael Banck wrote:
> >
> >> Hi,
> >>
> >> On Mon, Aug 27, 2018 at 07:53:36PM +0900, Yugo Nagata wrote:
> >>> On Fri, 24 Aug 2018 18:01
> On 27 Aug 2018, at 14:05, Yugo Nagata wrote:
>
> On Mon, 27 Aug 2018 13:34:12 +0200
> Michael Banck wrote:
>
>> Hi,
>>
>> On Mon, Aug 27, 2018 at 07:53:36PM +0900, Yugo Nagata wrote:
>>> On Fri, 24 Aug 2018 18:01:09 +0200
>>> Peter Eisentraut wrote:
I'm curious about this option:
On Mon, 27 Aug 2018 13:34:12 +0200
Michael Banck wrote:
> Hi,
>
> On Mon, Aug 27, 2018 at 07:53:36PM +0900, Yugo Nagata wrote:
> > On Fri, 24 Aug 2018 18:01:09 +0200
> > Peter Eisentraut wrote:
> > > I'm curious about this option:
> > >
> > > -r RELFILENODE check only relation with s
Hi,
On Mon, Aug 27, 2018 at 07:53:36PM +0900, Yugo Nagata wrote:
> On Fri, 24 Aug 2018 18:01:09 +0200
> Peter Eisentraut wrote:
> > I'm curious about this option:
> >
> > -r RELFILENODE check only relation with specified relfilenode
> >
> > but there is no facility to specify a databa
On Fri, 24 Aug 2018 18:01:09 +0200
Peter Eisentraut wrote:
> I'm curious about this option:
>
> -r RELFILENODE check only relation with specified relfilenode
>
> but there is no facility to specify a database.
>
> Also, referring to the relfilenode of a mapped relation seems a bit
>
I'm curious about this option:
-r RELFILENODE check only relation with specified relfilenode
but there is no facility to specify a database.
Also, referring to the relfilenode of a mapped relation seems a bit
inaccurate.
Maybe reframing this in terms of the file name of the file you w
25 matches
Mail list logo
