Re: pg_upgrade test writes to source directory

Hi, On 2022-08-16 11:33:12 -0400, Andrew Dunstan wrote: > On 2022-08-15 Mo 23:20, Andres Freund wrote: > > > > I've also attached a 0003 that splits the log location from the data > > location. That could be used to make the log file location symmetrical > > between > > pg_regress (log/) and tap

Re: pg_upgrade test writes to source directory

On 2022-08-15 Mo 23:20, Andres Freund wrote: > > I've also attached a 0003 that splits the log location from the data > location. That could be used to make the log file location symmetrical between > pg_regress (log/) and tap tests (tmp_check/log). But it'd break the > buildfarm's tap test log

Re: pg_upgrade test writes to source directory

Andres Freund writes: > On 2022-08-11 11:26:39 -0400, Tom Lane wrote: >> Given that it's no longer going to be the same tmp_check dir used >> elsewhere, maybe we could s/tmp_check/tab_comp_dir/g or something >> like that? That'd add some clarity I think. > Done in the attached patch (0001). I w

Re: pg_upgrade test writes to source directory

Hi, On 2022-08-15 20:20:51 -0700, Andres Freund wrote: > On 2022-08-11 11:26:39 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On 2022-06-01 10:55:28 -0400, Tom Lane wrote: > > >> [...] I'm definitely not happy with the proposed changes to > > >> 010_tab_completion.pl. My recollection is

Re: pg_upgrade test writes to source directory

Hi, On 2022-08-11 11:26:39 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-06-01 10:55:28 -0400, Tom Lane wrote: > >> [...] I'm definitely not happy with the proposed changes to > >> 010_tab_completion.pl. My recollection is that those tests > >> were intentionally written to test tab

Re: pg_upgrade test writes to source directory

Andres Freund writes: > On 2022-06-01 10:55:28 -0400, Tom Lane wrote: >> [...] I'm definitely not happy with the proposed changes to >> 010_tab_completion.pl. My recollection is that those tests >> were intentionally written to test tab completion involving a >> directory name, but this change ju

Re: pg_upgrade test writes to source directory

Hi, On 2022-06-01 10:55:28 -0400, Tom Lane wrote: > [...] I'm definitely not happy with the proposed changes to > 010_tab_completion.pl. My recollection is that those tests > were intentionally written to test tab completion involving a > directory name, but this change just loses that aspect ent

Re: pg_upgrade test writes to source directory

On Thu, Jun 02, 2022 at 08:50:12PM -0700, Andres Freund wrote: > +1 OK, applied the extra chdir to PostgreSQL::Test::Utils::tmp_check, as initially suggested by Peter. The CI looked happy on that. -- Michael signature.asc Description: PGP signature

Re: pg_upgrade test writes to source directory

On 2022-06-03 12:29:04 +0900, Michael Paquier wrote: > On Thu, Jun 02, 2022 at 05:17:34PM -0400, Andrew Dunstan wrote: > > I hope we fix the original issue soon - it's apparently been the cause > > of numerous buildfarm failures that it was on my list to investigate > > e.g. > >

Re: pg_upgrade test writes to source directory

On Thu, Jun 02, 2022 at 05:17:34PM -0400, Andrew Dunstan wrote: > I hope we fix the original issue soon - it's apparently been the cause > of numerous buildfarm failures that it was on my list to investigate > e.g. >

Re: pg_upgrade test writes to source directory

On 2022-06-01 We 20:37, Michael Paquier wrote: > On Wed, Jun 01, 2022 at 02:11:12PM -0700, Andres Freund wrote: >> Until recently TESTDIR needed to point to the build directory containing the >> binaries. But I'd like to be able to separate test log output from the build >> tree, so that it's eas

Re: pg_upgrade test writes to source directory

On Wed, Jun 01, 2022 at 02:11:12PM -0700, Andres Freund wrote: > Until recently TESTDIR needed to point to the build directory containing the > binaries. But I'd like to be able to separate test log output from the build > tree, so that it's easier to capture files generated by tests for CI / > bui

Re: pg_upgrade test writes to source directory

Hi, On 2022-06-01 16:11:16 +0200, Peter Eisentraut wrote: > On 31.05.22 09:17, Michael Paquier wrote: > > On Sat, May 28, 2022 at 04:14:01PM -0400, Tom Lane wrote: > > > Yeah, I'd noticed the obsoleted comments too, but not bothered to complain > > > since that was just WIP and not an officially p

Re: pg_upgrade test writes to source directory

Peter Eisentraut writes: > On 31.05.22 09:17, Michael Paquier wrote: >> Well, here is a formal patch set, then. Please feel free to comment. >> >> FWIW, I am on the fence with dropping TESTDIR, as it could be used by >> out-of-core test code as well. If there are doubts about >> back-patching t

Re: pg_upgrade test writes to source directory

On 31.05.22 09:17, Michael Paquier wrote: On Sat, May 28, 2022 at 04:14:01PM -0400, Tom Lane wrote: Yeah, I'd noticed the obsoleted comments too, but not bothered to complain since that was just WIP and not an officially proposed patch. I'll be happy to review if you want to put up a full patch

Re: pg_upgrade test writes to source directory

On Sat, May 28, 2022 at 04:14:01PM -0400, Tom Lane wrote: > Yeah, I'd noticed the obsoleted comments too, but not bothered to complain > since that was just WIP and not an officially proposed patch. I'll be > happy to review if you want to put up a full patch. Well, here is a formal patch set, th

Re: pg_upgrade test writes to source directory

Andres Freund writes: > I suspect there might be a bit more polish might be needed - that's why I > hadn't proposed the commit on its own yet. Yeah, I'd noticed the obsoleted comments too, but not bothered to complain since that was just WIP and not an officially proposed patch. I'll be happy to

Re: pg_upgrade test writes to source directory

Hi, On 2022-05-27 09:05:43 +0900, Michael Paquier wrote: > On Thu, May 26, 2022 at 07:51:08PM -0400, Tom Lane wrote: > > I wouldn't object to doing that, and even back-patching. It looked > > like a pretty sane change, and we've learned before that skimping on > > back-branch test infrastructure

Re: pg_upgrade test writes to source directory

On 28.05.22 10:56, Michael Paquier wrote: On Fri, May 27, 2022 at 02:45:57PM +0200, Peter Eisentraut wrote: I think you can just chdir to ${PostgreSQL::Test::Utils::tmp_check}. Hmm. I think that I prefer your initial suggestion with TESTOUTDIR. This sticks better in the long term, while makin

Re: pg_upgrade test writes to source directory

On Fri, May 27, 2022 at 02:45:57PM +0200, Peter Eisentraut wrote: > I think you can just chdir to ${PostgreSQL::Test::Utils::tmp_check}. Hmm. I think that I prefer your initial suggestion with TESTOUTDIR. This sticks better in the long term, while making things consistent with 010_tab_completion.

Re: pg_upgrade test writes to source directory

On 26.05.22 22:52, Justin Pryzby wrote: On Fri, May 27, 2022 at 05:43:04AM +0900, Michael Paquier wrote: On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote: I chose TESTOUTDIR because it corresponds to the tmp_check directory, so that the output files of the pg_upgrade run are rem

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 07:51:08PM -0400, Tom Lane wrote: > I wouldn't object to doing that, and even back-patching. It looked > like a pretty sane change, and we've learned before that skimping on > back-branch test infrastructure is a poor tradeoff. Okay, fine by me. Andres, what do you think

Re: pg_upgrade test writes to source directory

Michael Paquier writes: > On Thu, May 26, 2022 at 06:19:56PM -0400, Tom Lane wrote: >> It looks like that patch is meant to resolve misbehaviors equivalent to >> this one that already exist in several other places. So fixing this >> one along with the other ones seems like an appropriate thing to

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 06:19:56PM -0400, Tom Lane wrote: > It looks like that patch is meant to resolve misbehaviors equivalent to > this one that already exist in several other places. So fixing this > one along with the other ones seems like an appropriate thing to do > when that lands. Well,

Re: pg_upgrade test writes to source directory

Michael Paquier writes: > On Thu, May 26, 2022 at 03:52:18PM -0500, Justin Pryzby wrote: >> It looks like Peter working on top of the meson branch. >> TESTOUTDIR is not yet in master. > Well, we need to do something about that on HEAD, and it also means > that TESTDIR is the best fit for the jo

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 03:52:18PM -0500, Justin Pryzby wrote: > It looks like Peter working on top of the meson branch. > TESTOUTDIR is not yet in master. Thanks for the reference. I didn't know this part of the puzzle. > https://commitfest.postgresql.org/38/3395/ > https://github.com/anaraze

Re: pg_upgrade test writes to source directory

On Fri, May 27, 2022 at 05:43:04AM +0900, Michael Paquier wrote: > On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote: > > I chose TESTOUTDIR because it corresponds to the tmp_check directory, so > > that the output files of the pg_upgrade run are removed when the test > > artifacts a

Re: pg_upgrade test writes to source directory

On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote: > I chose TESTOUTDIR because it corresponds to the tmp_check directory, so > that the output files of the pg_upgrade run are removed when the test > artifacts are cleaned up. When using TESTDIR, the pg_upgrade output files > end up

Re: pg_upgrade test writes to source directory

On 25.05.22 09:25, Michael Paquier wrote: It looks like an addition of chdir $ENV{TESTOUTDIR}; could fix it. Please check the patch. I think that you mean TESTDIR, and not TESTOUTDIR? I chose TESTOUTDIR because it corresponds to the tmp_check directory, so that the output files of the

Re: pg_upgrade test writes to source directory

On Wed, May 25, 2022 at 08:21:26AM +0200, Peter Eisentraut wrote: > The 002_pg_upgrade.pl test leaves a file delete_old_cluster.sh in the source > directory. In vpath builds, there shouldn't be any files written to the > source directory. > > Note that the TAP tests run with the source directory a

pg_upgrade test writes to source directory

The 002_pg_upgrade.pl test leaves a file delete_old_cluster.sh in the source directory. In vpath builds, there shouldn't be any files written to the source directory. Note that the TAP tests run with the source directory as the current directory, so this is the result of pg_upgrade leaving it