Re: pg_upgrade generated files in subdir follow-up

2022-09-12 Thread Michael Paquier
On Mon, Sep 12, 2022 at 09:51:32AM +0200, Daniel Gustafsson wrote: > Sure, go for it. Thanks. Done, then, after an extra look. -- Michael signature.asc Description: PGP signature

Re: pg_upgrade generated files in subdir follow-up

2022-09-12 Thread Daniel Gustafsson
> On 12 Sep 2022, at 09:33, Michael Paquier wrote: > I have double-checked the whole code of pg_upgrade, and I am not seeing > another > area to fix, so 0001 looks fine to me. This one is on me, so I guess that I'd > like to take care of it myself. Sure, go for it. -- Daniel Gustafsson

Re: pg_upgrade generated files in subdir follow-up

2022-09-12 Thread Michael Paquier
On Fri, Sep 09, 2022 at 11:07:41AM -0500, Justin Pryzby wrote: > On Wed, Aug 31, 2022 at 04:41:24PM +0200, Daniel Gustafsson wrote: > > > On 31 Aug 2022, at 15:59, Tom Lane wrote: > > > > > > Daniel Gustafsson writes: > > >> Commit 38bfae36526 moved the .txt files pg_upgrade generates to a > >

Re: pg_upgrade generated files in subdir follow-up

2022-09-09 Thread Justin Pryzby
uture. -- Justin >From 36aaf5470d5b0bb0ad2a322880e526b8c5f87066 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 31 Aug 2022 14:09:06 +0200 Subject: [PATCH 1/2] pg_upgrade generated files in subdir follow-up Commit 38bfae36526 moved the .txt files pg_upgrade generates to a separa

Re: pg_upgrade generated files in subdir follow-up

2022-08-31 Thread Daniel Gustafsson
> On 31 Aug 2022, at 15:59, Tom Lane wrote: > > Daniel Gustafsson writes: >> Commit 38bfae36526 moved the .txt files pg_upgrade generates to a separate >> subdir, but there are a few left which are written to cwd. The thread >> resulting in that patch doesn't discuss these files specifically so

Re: pg_upgrade generated files in subdir follow-up

2022-08-31 Thread Tom Lane
Daniel Gustafsson writes: > Commit 38bfae36526 moved the .txt files pg_upgrade generates to a separate > subdir, but there are a few left which are written to cwd. The thread > resulting in that patch doesn't discuss these files specifically so it seems > they are just an oversight. Unless I'm mi

pg_upgrade generated files in subdir follow-up

2022-08-31 Thread Daniel Gustafsson
Commit 38bfae36526 moved the .txt files pg_upgrade generates to a separate subdir, but there are a few left which are written to cwd. The thread resulting in that patch doesn't discuss these files specifically so it seems they are just an oversight. Unless I'm missing something. Should something