Re: pg_stat_database.checksum_failures vs shared relations

2025-03-30 Thread Magnus Hagander
On Sat, Mar 29, 2025 at 7:09 PM Andres Freund wrote: > Hi, > > On 2025-03-29 13:17:44 -0400, Andres Freund wrote: > > On 2025-03-28 13:47:16 -0400, Andres Freund wrote: > > > Attached is a fix for the issue. > > > > I plan to push this fix soon, unless somebody protests... > > And done. > Hi! S

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-29 Thread Andres Freund
Hi, On 2025-03-29 13:17:44 -0400, Andres Freund wrote: > On 2025-03-28 13:47:16 -0400, Andres Freund wrote: > > Attached is a fix for the issue. > > I plan to push this fix soon, unless somebody protests... And done. Greetings, Andres Freund

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-29 Thread Andres Freund
Hi, On 2025-03-28 13:47:16 -0400, Andres Freund wrote: > Attached is a fix for the issue. I plan to push this fix soon, unless somebody protests... Greetings, Andres Freund

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-28 Thread Andres Freund
Hi, Attached is a fix for the issue. I looked around and didn't find extensions using PageIsVerified[Extended]() in codesearch.debian.org, so I got rid of the compat macro and renamed PageIsVerifiedExtended back to PageIsVerified(). Normally I'd commit tests as part of a fix like this, but since

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-27 Thread Andres Freund
Hi, On 2025-03-28 09:44:58 +0900, Michael Paquier wrote: > On Thu, Mar 27, 2025 at 12:06:45PM -0400, Robert Haas wrote: > > On Thu, Mar 27, 2025 at 11:58 AM Andres Freund wrote: > > > So, today we have the weird situation that *some* checksum errors on > > > shared > > > relations get attributed

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-27 Thread Julien Rouhaud
On Thu, Mar 27, 2025 at 09:02:02PM -0400, Andres Freund wrote: > Hi, > > On 2025-03-28 09:44:58 +0900, Michael Paquier wrote: > > On Thu, Mar 27, 2025 at 12:06:45PM -0400, Robert Haas wrote: > > > On Thu, Mar 27, 2025 at 11:58 AM Andres Freund wrote: > > > > So, today we have the weird situation t

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-27 Thread Michael Paquier
On Thu, Mar 27, 2025 at 12:06:45PM -0400, Robert Haas wrote: > On Thu, Mar 27, 2025 at 11:58 AM Andres Freund wrote: > > So, today we have the weird situation that *some* checksum errors on shared > > relations get attributed to the current database (if they happen in a > > backend > > normally a

Re: pg_stat_database.checksum_failures vs shared relations

2025-03-27 Thread Robert Haas
On Thu, Mar 27, 2025 at 11:58 AM Andres Freund wrote: > So, today we have the weird situation that *some* checksum errors on shared > relations get attributed to the current database (if they happen in a backend > normally accessing a shared relation), whereas others get reported to the > "shared

pg_stat_database.checksum_failures vs shared relations

2025-03-27 Thread Andres Freund
Hi, First - I find it rather shocking that we have absolutely *zero* tests of checksum failures in the backend. Zero. As evidenced by [1]. I really can't quite believe it. Nor do we have tests of ignore_checksum_failure or zero_damaged_pages. I was trying to write some tests for checksums vs A