Re: pg_shmem_allocations & documentation

2020-12-15 Thread Michael Paquier
On Tue, Dec 15, 2020 at 10:09:35AM +0900, Michael Paquier wrote: > Both of you seem to agree about having more details about that, which > is fine by me at the end. Horiguchi-san, do you have more thoughts to > offer? Benoit's version is similar to yours, just simpler. Okay, applied this one the

Re: pg_shmem_allocations & documentation

2020-12-14 Thread Michael Paquier
On Mon, Dec 14, 2020 at 10:33:06AM +0100, Benoit Lobréau wrote: > > > The offset at which the allocation starts. NULL for anonymous > - allocations and unused memory. > + allocations, since details related to them are not known. > Both of you seem to agr

Re: pg_shmem_allocations & documentation

2020-12-14 Thread Benoit Lobréau
Here's a proposal patch. Le ven. 11 déc. 2020 à 09:58, Benoit Lobréau a écrit : > Would "NULL for anonymous allocations, since details related to them are > not known." be ok ? > > > Le ven. 11 déc. 2020 à 09:29, Kyotaro Horiguchi > a écrit : > >> At Fri, 11 Dec 2020 14:42:45 +0900, Michael Paq

Re: pg_shmem_allocations & documentation

2020-12-11 Thread Benoit Lobréau
Would "NULL for anonymous allocations, since details related to them are not known." be ok ? Le ven. 11 déc. 2020 à 09:29, Kyotaro Horiguchi a écrit : > At Fri, 11 Dec 2020 14:42:45 +0900, Michael Paquier > wrote in > > On Fri, Dec 11, 2020 at 11:00:58AM +0900, Kyotaro Horiguchi wrote: > > > A

Re: pg_shmem_allocations & documentation

2020-12-11 Thread Kyotaro Horiguchi
At Fri, 11 Dec 2020 14:42:45 +0900, Michael Paquier wrote in > On Fri, Dec 11, 2020 at 11:00:58AM +0900, Kyotaro Horiguchi wrote: > > Although we could just rip some words off, I'd like to propose instead > > to add an explanation why it is not exposed for anonymous allocations, > > like the col

Re: pg_shmem_allocations & documentation

2020-12-10 Thread Michael Paquier
On Fri, Dec 11, 2020 at 11:00:58AM +0900, Kyotaro Horiguchi wrote: > Although we could just rip some words off, I'd like to propose instead > to add an explanation why it is not exposed for anonymous allocations, > like the column allocated_size. Indeed, there is a hiccup between what the code doe

Re: pg_shmem_allocations & documentation

2020-12-10 Thread Kyotaro Horiguchi
At Thu, 10 Dec 2020 11:07:47 +0100, Benoit Lobréau wrote in > Hi, > > While reading the documentation of pg_shmem_allocations, I noticed that the > off column is described as such : > > "The offset at which the allocation starts. NULL for anonymous allocations > and unused memory." > > Wherea

pg_shmem_allocations & documentation

2020-12-10 Thread Benoit Lobréau
Hi, While reading the documentation of pg_shmem_allocations, I noticed that the off column is described as such : "The offset at which the allocation starts. NULL for anonymous allocations and unused memory." Whereas, the view returns a value for unused memory: [local]:5433 postgres@postgres=#