Re: pg_rewind : feature to rewind promoted standby is broken!

2019-03-17 Thread Michael Paquier
On Thu, Mar 14, 2019 at 09:04:41AM +0900, Michael Paquier wrote: > Thanks for confirming, Mythun. I'll think about the logic of this > patch for a couple of days in the background, then I'll try to commit > it likely at the beginning of next week. Committed. I have spent extra time polishing the

Re: pg_rewind : feature to rewind promoted standby is broken!

2019-03-13 Thread Michael Paquier
On Thu, Mar 14, 2019 at 12:15:57AM +0530, Mithun Cy wrote: > I have not looked into the patch but quick test show it has fixed the above > issue. Thanks for confirming, Mythun. I'll think about the logic of this patch for a couple of days in the background, then I'll try to commit it likely at th

Re: pg_rewind : feature to rewind promoted standby is broken!

2019-03-13 Thread Mithun Cy
On Wed, Mar 13, 2019 at 1:38 PM Michael Paquier wrote: > On Tue, Mar 12, 2019 at 06:23:01PM +0900, Michael Paquier wrote: > > And you are pointing out to the correct commit. The issue is that > > process_target_file() has added a call to check_file_excluded(), and > > this skips all the folders

Re: pg_rewind : feature to rewind promoted standby is broken!

2019-03-13 Thread Michael Paquier
On Tue, Mar 12, 2019 at 06:23:01PM +0900, Michael Paquier wrote: > And you are pointing out to the correct commit. The issue is that > process_target_file() has added a call to check_file_excluded(), and > this skips all the folders which it thinks can be skipped. One > problem though is that we

pg_rewind : feature to rewind promoted standby is broken!

2019-03-12 Thread Mithun Cy
I think pg_rewind's feature to rewind the promoted standby as a new standby is broken in 11 STEPS: 1. create master standby setup. Use below script for same. 2. Promote the standby [mithuncy@localhost pgrewmasterbin]$ ./bin/pg_ctl -D standby promote waiting for server to promote done server p

Re: pg_rewind : feature to rewind promoted standby is broken!

2019-03-12 Thread Michael Paquier
On Tue, Mar 12, 2019 at 01:23:51PM +0530, Mithun Cy wrote: > I think pg_rewind's feature to rewind the promoted standby as a new > standby is broken in 11 Confirmed, it is. > Also I have tested same in version 10 it works fine there. > > Did below commit has broken this feature? (Thanks to kunta