I wrote:
> Isn't the real problem that lo_write returns int, not size_t?
After looking at it some more, I decided that we'd just been lazy
to begin with: we should be handling this as a regular SQL error
condition. Pushed at 929c69aa19.
regards, tom lane
Justin Pryzby writes:
> I overflowed my homedir while testing with pg_reload, and got:
> |pg_restore: error: could not write to large object (result:
> 18446744073709551615, expected: 30)
Bleah.
> I guess casting to long was the best option c. 2002 (commit 6faf8024f) but I
> gather the modern w
I overflowed my homedir while testing with pg_reload, and got:
|pg_restore: error: could not write to large object (result:
18446744073709551615, expected: 30)
src/bin/pg_dump/pg_backup_archiver.c
f (res != AH->lo_buf_used)
fatal("could not write to large object (result: %lu,
On Fri, May 08, 2020 at 07:45:16PM -0400, Alvaro Herrera wrote:
> Yeah, there's a lot of frontend code that uses free() instead of
> pg_free(). There are too many of these that worrying about a single one
> would not improve things much. I guess we could convert them all, but I
> don't see much p
On 2020-May-07, Ranier Vilela wrote:
> Can suggest improvements?
>
> 1. free (398 line) must be pg_free(buf)';
Yeah, there's a lot of frontend code that uses free() instead of
pg_free(). There are too many of these that worrying about a single one
would not improve things much. I guess we coul
On 2020-May-07, Euler Taveira wrote:
> While investigating a pg_restore error, I stumbled upon a message that is
> not so useful.
>
> pg_restore: error: could not close data file: No such file or directory
>
> Which file? File name should be printed too like in the error check for
> cfopen_read
Em qui., 7 de mai. de 2020 às 18:54, Euler Taveira <
euler.tave...@2ndquadrant.com> escreveu:
> Hi,
>
> While investigating a pg_restore error, I stumbled upon a message that is
> not so useful.
>
> pg_restore: error: could not close data file: No such file or directory
>
> Which file? File name s
Hi,
While investigating a pg_restore error, I stumbled upon a message that is
not so useful.
pg_restore: error: could not close data file: No such file or directory
Which file? File name should be printed too like in the error check for
cfopen_read a few lines above.
Regards,
--
Euler Taveira
