Re: pg_regress.c also sensitive to various PG* environment variables

2021-06-13 Thread Michael Paquier
On Sat, Jun 12, 2021 at 09:10:06AM +0900, Michael Paquier wrote: > Good idea, thanks. I'll add comments for each one that cannot be > unsetted. And done, finally. -- Michael signature.asc Description: PGP signature

Re: pg_regress.c also sensitive to various PG* environment variables

2021-06-11 Thread Michael Paquier
On Fri, Jun 11, 2021 at 10:08:20AM -0400, Alvaro Herrera wrote: > I think if they're to be kept in sync, then the exceptions should be > noted. I mean, where PGCLIENTENCODING would otherwise be, I'd add > /* PGCLIENTENCODING set above */ > /* See below for PGHOSTADDR */ > and so on (PGHOST and PGP

Re: pg_regress.c also sensitive to various PG* environment variables

2021-06-11 Thread Alvaro Herrera
On 2021-Jun-11, Michael Paquier wrote: > Following up with the recent thread that dealt with the same $subject > for the TAP tests, I have gone through pg_regress.c: > https://www.postgresql.org/message-id/ylbjjrpuciez7...@paquier.xyz Good idea. > The list of environment variables that had bette

pg_regress.c also sensitive to various PG* environment variables

2021-06-11 Thread Michael Paquier
Hi all, Following up with the recent thread that dealt with the same $subject for the TAP tests, I have gone through pg_regress.c: https://www.postgresql.org/message-id/ylbjjrpuciez7...@paquier.xyz The list of environment variables that had better be reset when using a temporary instance is very