Re: pg_receivewal: remove extra conn = NULL; in StreamLog

2021-09-02 Thread Daniel Gustafsson
> On 1 Sep 2021, at 10:58, Bharath Rupireddy > wrote: > > On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson wrote: >> >>> On 28 Aug 2021, at 14:10, Bharath Rupireddy >>> wrote: >> >>> It seems there's a redundant assignment statement conn = NULL in >>> pg_receivewal's StreamLog function. At

Re: pg_receivewal: remove extra conn = NULL; in StreamLog

2021-09-01 Thread Bharath Rupireddy
On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson wrote: > > > On 28 Aug 2021, at 14:10, Bharath Rupireddy > > wrote: > > > It seems there's a redundant assignment statement conn = NULL in > > pg_receivewal's StreamLog function. Attaching a tiny patch herewith. > > Thoughts? > > Agreed, while ha

Re: pg_receivewal: remove extra conn = NULL; in StreamLog

2021-08-28 Thread Daniel Gustafsson
> On 28 Aug 2021, at 14:10, Bharath Rupireddy > wrote: > It seems there's a redundant assignment statement conn = NULL in > pg_receivewal's StreamLog function. Attaching a tiny patch herewith. > Thoughts? Agreed, while harmless this is superfluous since conn is already set to NULL after the PQf

pg_receivewal: remove extra conn = NULL; in StreamLog

2021-08-28 Thread Bharath Rupireddy
Hi, It seems there's a redundant assignment statement conn = NULL in pg_receivewal's StreamLog function. Attaching a tiny patch herewith. Thoughts? Regards, Bharath Rupireddy. v1-0001-pg_receivewal-remove-extra-conn-NULL-in-StreamLog.patch Description: Binary data