Re: pg_log_fatal vs pg_log_error

2019-07-10 Thread Antonin Houska
Peter Eisentraut wrote: > On 2019-06-17 14:19, Antonin Houska wrote: > > Can anyone please give me a hint (and possibly add some comments to the > > code) > > when pg_log_fatal() should be used in frontend code and when it's > > appropriate > > to call pg_log_error()? The current use does not s

Re: pg_log_fatal vs pg_log_error

2019-06-17 Thread Peter Eisentraut
On 2019-06-17 14:19, Antonin Houska wrote: > Can anyone please give me a hint (and possibly add some comments to the code) > when pg_log_fatal() should be used in frontend code and when it's appropriate > to call pg_log_error()? The current use does not seem very consistent. For a program that run

Re: pg_log_fatal vs pg_log_error

2019-06-17 Thread Michael Paquier
On Mon, Jun 17, 2019 at 03:39:49PM +0200, Antonin Houska wrote: > I'd understand this if pg_log_fatal() called exit() itself, but it does not > (unless I miss something). Oops. My apologies. I have my own wrapper of pg_log_fatal() for an internal tool which does an exit on top of the logging in

Re: pg_log_fatal vs pg_log_error

2019-06-17 Thread Antonin Houska
Michael Paquier wrote: > On Mon, Jun 17, 2019 at 02:19:30PM +0200, Antonin Houska wrote: > > I'd expect that the pg_log_fatal() should be called when the error is > > serious > > enough to cause premature exit, but I can see cases where even > > pg_log_error() > > is followed by exit(1). pg_wal

Re: pg_log_fatal vs pg_log_error

2019-06-17 Thread Michael Paquier
On Mon, Jun 17, 2019 at 02:19:30PM +0200, Antonin Houska wrote: > I'd expect that the pg_log_fatal() should be called when the error is serious > enough to cause premature exit, but I can see cases where even pg_log_error() > is followed by exit(1). pg_waldump makes me feel that pg_log_error() is u

pg_log_fatal vs pg_log_error

2019-06-17 Thread Antonin Houska
Can anyone please give me a hint (and possibly add some comments to the code) when pg_log_fatal() should be used in frontend code and when it's appropriate to call pg_log_error()? The current use does not seem very consistent. I'd expect that the pg_log_fatal() should be called when the error is s