Re: pg_get_indexdef() modification to use TxnSnapshot

2024-01-05 Thread Robert Haas
On Thu, Oct 5, 2023 at 11:15 PM Tom Lane wrote: > kuroda.keis...@nttcom.co.jp writes: > > On 2023-06-14 15:31, vignesh C wrote: > >> I have attempted to convert pg_get_indexdef() to use > >> systable_beginscan() based on transaction-snapshot rather than using > >> SearchSysCache(). > > Has anybody

Re: pg_get_indexdef() modification to use TxnSnapshot

2023-10-05 Thread Tom Lane
kuroda.keis...@nttcom.co.jp writes: > On 2023-06-14 15:31, vignesh C wrote: >> I have attempted to convert pg_get_indexdef() to use >> systable_beginscan() based on transaction-snapshot rather than using >> SearchSysCache(). Has anybody thought about the fact that ALTER TABLE ALTER TYPE (specifica

Re: pg_get_indexdef() modification to use TxnSnapshot

2023-10-05 Thread kuroda . keisuke
Hi hackers, With '0001-pg_get_indexdef-modification-to-access-catalog-based.patch' patch, I confirmed that definition information can be collected even if the index is droped during pg_dump. The regression test (make check-world) has passed. I also tested the view definition for a similar prob

Re: pg_get_indexdef() modification to use TxnSnapshot

2023-06-13 Thread vignesh C
On Tue, 13 Jun 2023 at 11:49, Masahiko Sawada wrote: > > On Fri, May 26, 2023 at 6:55 PM shveta malik wrote: > > > > I have attempted to convert pg_get_indexdef() to use > > systable_beginscan() based on transaction-snapshot rather than using > > SearchSysCache(). The latter does not have any old

Re: pg_get_indexdef() modification to use TxnSnapshot

2023-06-12 Thread Masahiko Sawada
On Fri, May 26, 2023 at 6:55 PM shveta malik wrote: > > I have attempted to convert pg_get_indexdef() to use > systable_beginscan() based on transaction-snapshot rather than using > SearchSysCache(). The latter does not have any old info and thus > provides only the latest info as per the committe

Re: pg_get_indexdef() modification to use TxnSnapshot

2023-05-26 Thread vignesh C
On Fri, 26 May 2023 at 15:25, shveta malik wrote: > > I have attempted to convert pg_get_indexdef() to use > systable_beginscan() based on transaction-snapshot rather than using > SearchSysCache(). The latter does not have any old info and thus > provides only the latest info as per the committed

pg_get_indexdef() modification to use TxnSnapshot

2023-05-26 Thread shveta malik
I have attempted to convert pg_get_indexdef() to use systable_beginscan() based on transaction-snapshot rather than using SearchSysCache(). The latter does not have any old info and thus provides only the latest info as per the committed txns, which could result in errors in some scenarios. One suc