Re: pg_dump partitions can lead to inconsistent state after restore

2019-06-20 Thread Amit Langote
On Thu, Apr 25, 2019 at 4:01 AM Alvaro Herrera wrote: > So, while testing this I noticed that pg_restore fails with deadlocks if > you do a parallel restore if the --load-via-partition-root switch was > given to pg_dump. Is that a known bug? Was investigating --load-via-partition-root with a cow

Re: pg_dump partitions can lead to inconsistent state after restore

2019-04-24 Thread Alvaro Herrera
So, while testing this I noticed that pg_restore fails with deadlocks if you do a parallel restore if the --load-via-partition-root switch was given to pg_dump. Is that a known bug? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Tr

Re: pg_dump partitions can lead to inconsistent state after restore

2019-04-24 Thread David Rowley
On Wed, 24 Apr 2019 at 14:53, Amit Langote wrote: > > On 2019/04/24 10:19, David Rowley wrote: > > ERROR: invalid input syntax for type integer: "One" > > LINE 1: INSERT INTO public.listp1 VALUES ('One', 1); > > > > That settles the debate on the other thread... > > +1 to fixing this, although +0

Re: pg_dump partitions can lead to inconsistent state after restore

2019-04-23 Thread Amit Langote
On 2019/04/24 10:19, David Rowley wrote: > On Wed, 24 Apr 2019 at 06:50, Alvaro Herrera wrote: >> Per my comment at https://postgr.es/m/2019045129.GA6126@alvherre.pgsql >> I think that pg_dump can possibly cause bogus partition definitions, >> when the users explicitly decide to join tables as

Re: pg_dump partitions can lead to inconsistent state after restore

2019-04-23 Thread David Rowley
On Wed, 24 Apr 2019 at 06:50, Alvaro Herrera wrote: > Per my comment at https://postgr.es/m/2019045129.GA6126@alvherre.pgsql > I think that pg_dump can possibly cause bogus partition definitions, > when the users explicitly decide to join tables as partitions that have > different column order

pg_dump partitions can lead to inconsistent state after restore

2019-04-23 Thread Alvaro Herrera
Per my comment at https://postgr.es/m/2019045129.GA6126@alvherre.pgsql I think that pg_dump can possibly cause bogus partition definitions, when the users explicitly decide to join tables as partitions that have different column ordering than the parent table. Any COPY or INSERT command withou