Re: pg_dump compatibility level / use create view instead of create table/rule

2019-10-26 Thread Tom Lane
Andres Freund writes: > On 2019-10-10 11:20:14 -0400, Tom Lane wrote: >> The reason we get "REPLICA IDENTITY NOTHING" is that a view's relreplident >> is set to 'n' not 'd', which might not have been a great choice. > Hm, yea. I wonder if we should add a REPLICA_IDENTITY_INVALID or such, > for no

Re: pg_dump compatibility level / use create view instead of create table/rule

2019-10-26 Thread Andres Freund
Hi, On 2019-10-10 11:20:14 -0400, Tom Lane wrote: > regression=# create table mytab (f1 int primary key, f2 text); > CREATE TABLE > regression=# create view myview as select * from mytab group by f1; > CREATE VIEW > > This situation is problematic for pg_dump because validity of the > view depend

Re: pg_dump compatibility level / use create view instead of create table/rule

2019-10-26 Thread Tom Lane
I wrote: > Alex Williams writes: >> [ gripes about pg_dump printing REPLICA IDENTITY NOTHING for a view ] > This is fixed in v10 and up thanks to d8c05aff5. I was hesitant to > back-patch that at the time, but now that it's survived in the field > for a couple years, I think a good case could be

Re: pg_dump compatibility level / use create view instead of create table/rule

2019-10-10 Thread Tom Lane
Alex Williams writes: > [ gripes about pg_dump printing REPLICA IDENTITY NOTHING for a view ] I spent a little bit of time trying to reproduce this, and indeed I can, in versions before v10. regression=# create table mytab (f1 int primary key, f2 text); CREATE TABLE regression=# create view myvi