Re: pg_dump --where option

2020-09-29 Thread Michael Paquier
On Mon, Sep 14, 2020 at 05:00:19PM +0200, Daniel Gustafsson wrote: > I'm not sure I follow. Surely tests can be added for this functionality? We should have tests for that. I can see that this has not been answered in two weeks, so this has been marked as returned with feedback in the CF app. --

Re: pg_dump --where option

2020-09-14 Thread Daniel Gustafsson
> On 14 Sep 2020, at 12:04, Surafel Temesgen wrote: > On Fri, Jul 31, 2020 at 1:38 AM Daniel Gustafsson > wrote: > > > $ pg_dump -d cary --where="test1:a3 = ( select max(aa1) from test2 )" > > > testdump2 > > $ pg_dump: error: processing of table "public.test1" failed

Re: pg_dump --where option

2020-09-14 Thread Surafel Temesgen
On Fri, Jul 31, 2020 at 1:38 AM Daniel Gustafsson wrote: > > > $ pg_dump -d cary --where="test1:a3 = ( select max(aa1) from test2 )" > > testdump2 > > $ pg_dump: error: processing of table "public.test1" failed > > > > both test1 and test2 exist in the database and the same subquery works > und

Re: pg_dump --where option

2020-07-30 Thread Daniel Gustafsson
> On 10 Jul 2020, at 02:03, Cary Huang wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed > Implements feature: tested, failed > Spec compliant: tested, failed > Documentation:tested, failed >

Re: pg_dump --where option

2020-07-09 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed Hi I had a look at the patch and it cleanly applies to postg

pg_dump --where option

2020-06-15 Thread Surafel Temesgen
Internally pg_dump have capability to filter the table data to dump by same filter clause but it have no interface to use it and the patch here [1] adds interface to it but it have at-least two issue, one is error message in case of incorrect where clause specification is somehow hard to debug and