Re: pg_createsubscriber: Fix incorrect handling of cleanup flags

2025-05-05 Thread Nisha Moond
On Mon, May 5, 2025 at 11:39 AM David G. Johnston wrote: > > On Sun, May 4, 2025 at 8:45 PM Nisha Moond wrote: >> >> Attached is the patch implementing the above proposed solution. >> Reviews and feedback are most welcome. > > > I feel like this is just papering over the issue - which is that the

Re: pg_createsubscriber: Fix incorrect handling of cleanup flags

2025-05-04 Thread David G. Johnston
On Sun, May 4, 2025 at 8:45 PM Nisha Moond wrote: > Attached is the patch implementing the above proposed solution. > Reviews and feedback are most welcome. > I feel like this is just papering over the issue - which is that these two drop functions are being used for multiple differently named p

pg_createsubscriber: Fix incorrect handling of cleanup flags

2025-05-04 Thread Nisha Moond
Hi Hackers, In pg_createsubscriber, the flags 'made_publication' and 'made_replslot' are used to track whether the tool itself created a publication or replication slot on the primary (publisher) node. If a failure happens during the process, these flags help the tool decide whether it should clea