Re: pg_constraint.conincluding is useless

2018-09-07 Thread Tom Lane
Bruce Momjian writes: > On Sun, Sep 2, 2018 at 01:27:25PM -0400, Tom Lane wrote: >> If we do do a bump for beta4, I'd be strongly tempted to address the >> lack of a unique index for pg_constraint as well, cf >> https://www.postgresql.org/message-id/10110.1535907...@sss.pgh.pa.us > Uh, if we add

Re: pg_constraint.conincluding is useless

2018-09-07 Thread Alvaro Herrera
On 2018-Sep-07, Bruce Momjian wrote: > On Sun, Sep 2, 2018 at 01:27:25PM -0400, Tom Lane wrote: > > Alvaro Herrera writes: > > > This requires a catversion bump, for which it may seem a bit late; > > > however I think it's better to release pg11 without a useless catalog > > > column only to rem

Re: pg_constraint.conincluding is useless

2018-09-07 Thread Bruce Momjian
On Sun, Sep 2, 2018 at 01:27:25PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > This requires a catversion bump, for which it may seem a bit late; > > however I think it's better to release pg11 without a useless catalog > > column only to remove it in pg12 ... > > Catversion bumps during

Re: pg_constraint.conincluding is useless

2018-09-02 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > This requires a catversion bump, for which it may seem a bit late; > > however I think it's better to release pg11 without a useless catalog > > column only to remove it in pg12 ... Yeah, I really don't think we want

Re: pg_constraint.conincluding is useless

2018-09-02 Thread Michael Paquier
On Sun, Sep 02, 2018 at 01:27:25PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > This requires a catversion bump, for which it may seem a bit late; > > however I think it's better to release pg11 without a useless catalog > > column only to remove it in pg12 ... > > Catversion bumps during

Re: pg_constraint.conincluding is useless

2018-09-02 Thread Tom Lane
Alvaro Herrera writes: > This requires a catversion bump, for which it may seem a bit late; > however I think it's better to release pg11 without a useless catalog > column only to remove it in pg12 ... Catversion bumps during beta are routine. If we had put out rc1 I'd say it was too late, but

pg_constraint.conincluding is useless

2018-09-02 Thread Alvaro Herrera
Hi Already mentioned this in https://postgr.es/m/20180831205020.nxhw6ypysgshjtnl@alvherre.pgsql While trying to add support for foreign keys to partitioned tables, I noticed that commit 8224de4f42cc ("Indexes with INCLUDE columns and their support in B-tree") added a column to pg_constraint that