On Fri, Feb 19, 2021 at 09:57:22AM -0500, Tom Lane wrote:
> Hm. It should be consistent with the rest, for sure. Personally I'd put
> the only period at the end, but I suppose we should stick with the
> prevailing style if there is one.
Thanks. I have just used the same style as XML, LDAP and L
Michael Paquier writes:
> On Fri, Feb 19, 2021 at 02:21:21AM -0500, Tom Lane wrote:
>> +1, but I think the first period in this comment is redundant:
>> + AC_DEFINE([USE_OPENSSL], 1, [Define to 1 to build with OpenSSL support.
>> (--with-ssl=openssl).])
> I guess that you mean the second period
On Fri, Feb 19, 2021 at 02:21:21AM -0500, Tom Lane wrote:
> Michael Paquier writes:
> > Indeed, thanks. It looks like a "git add" that was fat-fingered. I
> > would like to make things more consistent with the attached.
>
> +1, but I think the first period in this comment is redundant:
>
> +
Michael Paquier writes:
> Indeed, thanks. It looks like a "git add" that was fat-fingered. I
> would like to make things more consistent with the attached.
+1, but I think the first period in this comment is redundant:
+ AC_DEFINE([USE_OPENSSL], 1, [Define to 1 to build with OpenSSL support.
On Fri, Feb 19, 2021 at 01:42:38AM -0500, Tom Lane wrote:
> Antonin Houska writes:
>> When I run "autoreconf" on the master branch, git generates the diff
>> below. Shouldn't it just be applied? I suppose someone changed configure.ac
>> and forgot to update the generated file.
>
> Yeah, looks lik
Antonin Houska writes:
> When I run "autoreconf" on the master branch, git generates the diff
> below. Shouldn't it just be applied? I suppose someone changed configure.ac
> and forgot to update the generated file.
Yeah, looks like fe61df7f8 is at fault. Michael?
regards
When I run "autoreconf" on the master branch, git generates the diff
below. Shouldn't it just be applied? I suppose someone changed configure.ac
and forgot to update the generated file.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
diff --git a/src/include/pg_config.h.in b/src/inclu
