Re: pg_combinebackup --clone doesn't work

2024-09-10 Thread Tomas Vondra
On 8/23/24 14:50, Tomas Vondra wrote: > > On 8/23/24 14:00, Peter Eisentraut wrote: >> On 30.06.24 20:58, Tomas Vondra wrote: >>> I've pushed the first three patches, fixing the headers, adding the >>> --copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable. >>> >>> I haven't pushed the CI change

Re: pg_combinebackup --clone doesn't work

2024-08-23 Thread Tomas Vondra
On 8/23/24 14:00, Peter Eisentraut wrote: > On 30.06.24 20:58, Tomas Vondra wrote: >> I've pushed the first three patches, fixing the headers, adding the >> --copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable. >> >> I haven't pushed the CI changes, I'm not sure if there's a clear >> consensu

Re: pg_combinebackup --clone doesn't work

2024-08-23 Thread Peter Eisentraut
On 30.06.24 20:58, Tomas Vondra wrote: I've pushed the first three patches, fixing the headers, adding the --copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable. I haven't pushed the CI changes, I'm not sure if there's a clear consensus on which combination to test. It's something we can twea

Re: pg_combinebackup --clone doesn't work

2024-06-30 Thread Tomas Vondra
Hi, I've pushed the first three patches, fixing the headers, adding the --copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable. I haven't pushed the CI changes, I'm not sure if there's a clear consensus on which combination to test. It's something we can tweak later, I think. FWIW I've added t

Re: pg_combinebackup --clone doesn't work

2024-06-25 Thread Tomas Vondra
On 6/25/24 15:21, Peter Eisentraut wrote: > On 21.06.24 18:10, Tomas Vondra wrote: >> On 6/21/24 00:07, Tomas Vondra wrote: >>> Here's a fix adding the missing headers to pg_combinebackup, and fixing >>> some compile-time issues in the ifdef-ed block. >>> >>> I've done some basic manual testing

Re: pg_combinebackup --clone doesn't work

2024-06-25 Thread Peter Eisentraut
On 21.06.24 18:10, Tomas Vondra wrote: On 6/21/24 00:07, Tomas Vondra wrote: Here's a fix adding the missing headers to pg_combinebackup, and fixing some compile-time issues in the ifdef-ed block. I've done some basic manual testing today - I plan to test this a bit more tomorrow, and I'll also

Re: pg_combinebackup --clone doesn't work

2024-06-21 Thread Tomas Vondra
On 6/21/24 00:07, Tomas Vondra wrote: > Here's a fix adding the missing headers to pg_combinebackup, and fixing > some compile-time issues in the ifdef-ed block. > > I've done some basic manual testing today - I plan to test this a bit > more tomorrow, and I'll also look at integrating this into t

Re: pg_combinebackup --clone doesn't work

2024-06-20 Thread Tomas Vondra
Here's a fix adding the missing headers to pg_combinebackup, and fixing some compile-time issues in the ifdef-ed block. I've done some basic manual testing today - I plan to test this a bit more tomorrow, and I'll also look at integrating this into the existing tests. regards -- Tomas Vondra E

Re: pg_combinebackup --clone doesn't work

2024-06-20 Thread Tomas Vondra
On 6/20/24 07:55, Peter Eisentraut wrote: > The pg_combinebackup --clone option currently doesn't work at all.  Even > on systems where it should it be supported, you'll always get a "file > cloning not supported on this platform" error. > > The reason is this checking code in pg_combinebackup.c:

pg_combinebackup --clone doesn't work

2024-06-19 Thread Peter Eisentraut
The pg_combinebackup --clone option currently doesn't work at all. Even on systems where it should it be supported, you'll always get a "file cloning not supported on this platform" error. The reason is this checking code in pg_combinebackup.c: #if (defined(HAVE_COPYFILE) && defined(COPYFILE_