Re: pg_checksums (or checksums in general) vs tableam

2019-07-11 Thread Magnus Hagander
On Thu, Jul 11, 2019 at 2:30 AM Michael Paquier wrote: > On Wed, Jul 10, 2019 at 09:19:03AM -0700, Andres Freund wrote: > > On July 10, 2019 9:12:18 AM PDT, Magnus Hagander > wrote: > >> That would be fine, if we actually knew. Should we (or have we already?) > >> defined a rule that they are no

Re: pg_checksums (or checksums in general) vs tableam

2019-07-10 Thread Michael Paquier
On Wed, Jul 10, 2019 at 09:19:03AM -0700, Andres Freund wrote: > On July 10, 2019 9:12:18 AM PDT, Magnus Hagander wrote: >> That would be fine, if we actually knew. Should we (or have we already?) >> defined a rule that they are not allowed to use the same naming standard >> unless they have the s

Re: pg_checksums (or checksums in general) vs tableam

2019-07-10 Thread Andres Freund
Hi, On July 10, 2019 9:12:18 AM PDT, Magnus Hagander wrote: >On Wed, Jul 10, 2019 at 3:05 PM Michael Paquier >wrote: > >> On Wed, Jul 10, 2019 at 11:42:34AM +0200, Magnus Hagander wrote: >> > pg_checksums enumerate the files. What if there are files there >from a >> > different tableam? Isn't pg

Re: pg_checksums (or checksums in general) vs tableam

2019-07-10 Thread Magnus Hagander
On Wed, Jul 10, 2019 at 3:05 PM Michael Paquier wrote: > On Wed, Jul 10, 2019 at 11:42:34AM +0200, Magnus Hagander wrote: > > pg_checksums enumerate the files. What if there are files there from a > > different tableam? Isn't pg_checksums just going to badly fail then, > since > > it assumes ever

Re: pg_checksums (or checksums in general) vs tableam

2019-07-10 Thread Michael Paquier
On Wed, Jul 10, 2019 at 11:42:34AM +0200, Magnus Hagander wrote: > pg_checksums enumerate the files. What if there are files there from a > different tableam? Isn't pg_checksums just going to badly fail then, since > it assumes everything is heap? > > Also, do we allow AMs that don't support check

pg_checksums (or checksums in general) vs tableam

2019-07-10 Thread Magnus Hagander
How is this intended to work? pg_checksums enumerate the files. What if there are files there from a different tableam? Isn't pg_checksums just going to badly fail then, since it assumes everything is heap? Also, do we allow AMs that don't support checksumming data? Do we have any checks for tabl