On Sat, Sep 21, 2024 at 02:48:32PM +0900, Fujii Masao wrote:
> On 2024/09/21 12:09, Tom Lane wrote:
>> Fujii Masao writes:
>> > I don´t have any objections to this commit, but I´d like to confirm
>> > whether we really want to proactively reorder #include directives,
>> > even for standard C libra
On 2024/09/21 12:09, Tom Lane wrote:
Fujii Masao writes:
I don’t have any objections to this commit, but I’d like to confirm
whether we really want to proactively reorder #include directives,
even for standard C library headers.
I'm hesitant to do that. We can afford to insist that our ow
Fujii Masao writes:
> I don’t have any objections to this commit, but I’d like to confirm
> whether we really want to proactively reorder #include directives,
> even for standard C library headers.
I'm hesitant to do that. We can afford to insist that our own header
files be inclusion-order-inde
On 2024/09/21 5:20, Nathan Bossart wrote:
On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote:
On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote:
I noticed two headers are not in alphabetical order in pg_checkums.c,
patch attached.
This appears to be commit 280e5f1's
On Fri, Sep 20, 2024 at 03:20:16PM -0500, Nathan Bossart wrote:
> On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote:
> > On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote:
> >> I noticed two headers are not in alphabetical order in pg_checkums.c,
> >> patch attached.
> >
>
On Fri, Sep 20, 2024 at 01:56:16PM -0500, Nathan Bossart wrote:
> On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote:
>> I noticed two headers are not in alphabetical order in pg_checkums.c,
>> patch attached.
>
> This appears to be commit 280e5f1's fault. Will fix.
Committed, thanks!
On Fri, Sep 20, 2024 at 07:20:15PM +0200, Michael Banck wrote:
> I noticed two headers are not in alphabetical order in pg_checkums.c,
> patch attached.
This appears to be commit 280e5f1's fault. Will fix.
--
nathan
Hi,
I noticed two headers are not in alphabetical order in pg_checkums.c,
patch attached.
Michael
>From e4d6d6503b4c14685424c6a04c5eb2ae29024bf6 Mon Sep 17 00:00:00 2001
From: Michael Banck
Date: Fri, 20 Sep 2024 19:17:43 +0200
Subject: [PATCH] Reorder headers in pg_checkums.c in alphabetical o
