Re: pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-11 Thread Fujii Masao
On 2020/02/11 0:28, Alvaro Herrera wrote: On 2020-Feb-10, Alvaro Herrera wrote: On 2020-Feb-10, Fujii Masao wrote: Yes! Thanks for pointing out that! So the patch needs to be applied only in master. Yikes, thanks. Pushing in a minute. Actually, if you want to push it, be my guest. Y

Re: pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-10 Thread Alvaro Herrera
On 2020-Feb-10, Fujii Masao wrote: > > > On 2020/02/10 17:23, Sergei Kornilov wrote: > > Hello > > > > Seems bug was introduced in caba97a9d9f4d4fa2531985fd12d3cd823da06f3 - in > > HEAD only > > > > In REL_12_STABLE we have: > > > > boolis_recovery_guc_supported = true; > >

Re: pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-10 Thread Alvaro Herrera
On 2020-Feb-10, Alvaro Herrera wrote: > On 2020-Feb-10, Fujii Masao wrote: > > Yes! Thanks for pointing out that! > > So the patch needs to be applied only in master. > > Yikes, thanks. Pushing in a minute. Actually, if you want to push it, be my guest. -- Álvaro Herrerahttps:

Re: pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-10 Thread Magnus Hagander
On Mon, Feb 10, 2020 at 9:41 AM Fujii Masao wrote: > > > > On 2020/02/10 17:23, Sergei Kornilov wrote: > > Hello > > > > Seems bug was introduced in caba97a9d9f4d4fa2531985fd12d3cd823da06f3 - in > > HEAD only > > > > In REL_12_STABLE we have: > > > > boolis_recovery_guc_supporte

Re: pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-10 Thread Fujii Masao
On 2020/02/10 17:23, Sergei Kornilov wrote: Hello Seems bug was introduced in caba97a9d9f4d4fa2531985fd12d3cd823da06f3 - in HEAD only In REL_12_STABLE we have: boolis_recovery_guc_supported = true; if (PQserverVersion(conn) < MINIMUM_VERSION_FOR_RECOVERY_GUC)

Re: pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-10 Thread Sergei Kornilov
Hello Seems bug was introduced in caba97a9d9f4d4fa2531985fd12d3cd823da06f3 - in HEAD only In REL_12_STABLE we have: boolis_recovery_guc_supported = true; if (PQserverVersion(conn) < MINIMUM_VERSION_FOR_RECOVERY_GUC) is_recovery_guc_supported = false;

pg_basebackup -F plain -R overwrites postgresql.auto.conf

2020-02-09 Thread Fujii Masao
Hi, I found that pg_basebackup -F plain -R *overwrites* postgresql.auto.conf taken from the primary server with new primary_conninfo setting, while pg_basebackup -F tar -R just *appends* it into the file. I think that this is a bug and pg_basebackup -F plain -R should *append* the setting