Re: pg_amcheck: Fix block number parsing on command line

2021-08-20 Thread Peter Eisentraut
On 22.07.21 18:18, Mark Dilger wrote: On Jul 22, 2021, at 7:56 AM, Peter Eisentraut wrote: Please check that it's up to speed. <0001-pg_amcheck-Fix-block-number-parsing-on-command-line.patch> This looks correct to me. Thanks for the fix. Committed this to 14 and master. Your use of strt

Re: pg_amcheck: Fix block number parsing on command line

2021-07-22 Thread Michael Paquier
On Thu, Jul 22, 2021 at 04:56:56PM +0200, Peter Eisentraut wrote: > It seems to me that when using the pg_amcheck --startblock and --endblock > options on platforms where sizeof(long) == 4, you cannot specify higher > block numbers (unless you do tricks with negative numbers). The attached > patch

Re: pg_amcheck: Fix block number parsing on command line

2021-07-22 Thread Mark Dilger
> On Jul 22, 2021, at 7:56 AM, Peter Eisentraut > wrote: > > Please check that it's up to speed. > <0001-pg_amcheck-Fix-block-number-parsing-on-command-line.patch> This looks correct to me. Thanks for the fix. Your use of strtoul compares favorably to that in pg_resetwal in that you are c

pg_amcheck: Fix block number parsing on command line

2021-07-22 Thread Peter Eisentraut
traut Date: Thu, 22 Jul 2021 16:49:37 +0200 Subject: [PATCH] pg_amcheck: Fix block number parsing on command line The previous code wouldn't handle higher block numbers on systems where sizeof(long) == 4. --- src/bin/pg_amcheck/pg_amcheck.c | 17 +++-- 1 file changed, 11 insert