Re: pg13: xlogreader API adjust

2020-05-21 Thread Kyotaro Horiguchi
At Fri, 15 May 2020 19:24:28 -0400, Alvaro Herrera wrote in > On 2020-May-15, Michael Paquier wrote: > > > On Thu, May 14, 2020 at 02:12:25PM +0900, Kyotaro Horiguchi wrote: > > > Good catch! That's not only for CreateDecodingContet. That happens > > > everywhere in the query loop in PostgresM

Re: pg13: xlogreader API adjust

2020-05-15 Thread Alvaro Herrera
On 2020-May-15, Michael Paquier wrote: > On Thu, May 14, 2020 at 02:12:25PM +0900, Kyotaro Horiguchi wrote: > > Good catch! That's not only for CreateDecodingContet. That happens > > everywhere in the query loop in PostgresMain() until logreader is > > initialized. So that also happens, for exam

Re: pg13: xlogreader API adjust

2020-05-15 Thread Michael Paquier
On Thu, May 14, 2020 at 02:12:25PM +0900, Kyotaro Horiguchi wrote: > Good catch! That's not only for CreateDecodingContet. That happens > everywhere in the query loop in PostgresMain() until logreader is > initialized. So that also happens, for example, by starting logical > replication using inv

Re: pg13: xlogreader API adjust

2020-05-13 Thread Kyotaro Horiguchi
At Thu, 14 May 2020 01:03:48 +, "Bossart, Nathan" wrote in > I think I've discovered a problem with 850196b6. The following steps > can be used to trigger a segfault: > > # wal_level = logical > psql postgres -c "create database testdb;" > psql testdb -c "select pg_

Re: pg13: xlogreader API adjust

2020-05-13 Thread Bossart, Nathan
I think I've discovered a problem with 850196b6. The following steps can be used to trigger a segfault: # wal_level = logical psql postgres -c "create database testdb;" psql testdb -c "select pg_create_logical_replication_slot('slot', 'test_decoding');" psql "dbna

Re: pg13: xlogreader API adjust

2020-05-13 Thread Alvaro Herrera
On 2020-May-13, Tom Lane wrote: > Alvaro Herrera writes: > > Pushed. Thanks for the help! > > This seems to have fixed bowerbird. Were you expecting that? Hm, not really. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training

Re: pg13: xlogreader API adjust

2020-05-13 Thread Tom Lane
Alvaro Herrera writes: > Pushed. Thanks for the help! This seems to have fixed bowerbird. Were you expecting that? regards, tom lane

Re: pg13: xlogreader API adjust

2020-05-13 Thread Alvaro Herrera
Pushed. Thanks for the help! -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pg13: xlogreader API adjust

2020-05-12 Thread Alvaro Herrera
On 2020-May-12, Kyotaro Horiguchi wrote: > I'm not sure the reason for wal_segment_open and WalSndSegmentOpen > being modified different way about error handling of BasicOpenFile, I > prefer the WalSndSegmentOpen way. However, that difference doesn't > harm anything so I'm fine with the current p

Re: pg13: xlogreader API adjust

2020-05-11 Thread Kyotaro Horiguchi
At Mon, 11 May 2020 16:33:36 -0400, Alvaro Herrera wrote in > Hello > > Per discussion in thread [1], I propose the following patch to give > another adjustment to the xlogreader API. This results in a small but > not insignificat net reduction of lines of code. What this patch does > is adju

pg13: xlogreader API adjust

2020-05-11 Thread Alvaro Herrera
Hello Per discussion in thread [1], I propose the following patch to give another adjustment to the xlogreader API. This results in a small but not insignificat net reduction of lines of code. What this patch does is adjust the signature of these new xlogreader callbacks, making the API simpler.