Re: perlcritic script

2018-05-08 Thread Tels
Moin, On Tue, May 8, 2018 5:03 pm, Peter Eisentraut wrote: > On 5/8/18 16:51, Tom Lane wrote: >> Peter Eisentraut writes: >>> On 5/8/18 13:57, Andrew Dunstan wrote: + # take executable files that file(1) thinks are perl files + find . -type f -perm -100 -exec file {} \; -print |

Re: perlcritic script

2018-05-08 Thread Peter Eisentraut
On 5/8/18 16:51, Tom Lane wrote: > Peter Eisentraut writes: >> On 5/8/18 13:57, Andrew Dunstan wrote: >>> + # take executable files that file(1) thinks are perl files >>> + find . -type f -perm -100 -exec file {} \; -print | >>> + egrep -i ':.*perl[0-9]*\>' | > >> How portable is that? > >

Re: perlcritic script

2018-05-08 Thread Tom Lane
Peter Eisentraut writes: > On 5/8/18 13:57, Andrew Dunstan wrote: >> +# take executable files that file(1) thinks are perl files >> +find . -type f -perm -100 -exec file {} \; -print | >> +egrep -i ':.*perl[0-9]*\>' | > How portable is that? Well, it's the same code that's in pgperlt

Re: perlcritic script

2018-05-08 Thread Peter Eisentraut
On 5/8/18 13:57, Andrew Dunstan wrote: > + # take executable files that file(1) thinks are perl files > + find . -type f -perm -100 -exec file {} \; -print | > + egrep -i ':.*perl[0-9]*\>' | How portable is that? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

perlcritic script

2018-05-08 Thread Andrew Dunstan
Here's a small patch to add a script to call perlcritic, in the same way that we have a script to call perltidy. Is also includes a perlcriticrc file containing a policy to allow octal constants with leading zeros. That's the only core severity 5 policy we are currently no in compliance with. W