Re: partitioning code reorganization

2018-04-23 Thread Amit Langote
On 2018/04/15 11:58, Amit Langote wrote: > On Sun, Apr 15, 2018 at 11:57 AM, Amit Langote > wrote: >> On Sun, Apr 15, 2018 at 9:17 AM, Alvaro Herrera >> wrote: >>> Thanks! I pushed this now, putting back the enum in parsenodes and >>> including this delta patch of yours. >> >> Thank you. Do y

Re: partitioning code reorganization

2018-04-19 Thread Amit Langote
On 2018/04/18 5:18, Alvaro Herrera wrote: > Amit Langote wrote: > >> 0001-Make-copying-of-cached-partitioning-info-more-con.patch >> 0002-Cache-all-partitioning-info-under-one-memory-cont.patch >> 0003-Cache-partsupfunc-separately-from-PartitionKey.patch > > I'd rather not do these patches now, u

Re: partitioning code reorganization

2018-04-17 Thread Alvaro Herrera
Amit Langote wrote: > 0001-Make-copying-of-cached-partitioning-info-more-con.patch > 0002-Cache-all-partitioning-info-under-one-memory-cont.patch > 0003-Cache-partsupfunc-separately-from-PartitionKey.patch I'd rather not do these patches now, unless there is some pressing reason to (eg. some bug

Re: partitioning code reorganization

2018-04-16 Thread Amit Langote
On 2018/04/15 9:17, Alvaro Herrera wrote: > Amit Langote wrote: >> On Sat, Apr 14, 2018 at 11:48 PM, Amit Langote >> wrote: >>> Hi. >>> >>> Thanks for taking care of few things I left like those PartitionKey >>> accessors in rel.h. >> >> Forgot to mention -- there are some files that still includ

Re: partitioning code reorganization

2018-04-14 Thread Amit Langote
On Sun, Apr 15, 2018 at 11:57 AM, Amit Langote wrote: > On Sun, Apr 15, 2018 at 9:17 AM, Alvaro Herrera > wrote: >> Thanks! I pushed this now, putting back the enum in parsenodes and >> including this delta patch of yours. > > Thank you. Do you think the following CF entry is good to be closed

Re: partitioning code reorganization

2018-04-14 Thread Amit Langote
On Sun, Apr 15, 2018 at 9:17 AM, Alvaro Herrera wrote: > Thanks! I pushed this now, putting back the enum in parsenodes and > including this delta patch of yours. Thank you. Do you think the following CF entry is good to be closed? Regards, Amit

Re: partitioning code reorganization

2018-04-14 Thread Alvaro Herrera
Amit Langote wrote: > On Sat, Apr 14, 2018 at 11:48 PM, Amit Langote > wrote: > > Hi. > > > > Thanks for taking care of few things I left like those PartitionKey > > accessors in rel.h. > > Forgot to mention -- there are some files that still include > catalog/partition.h but no longer need to.

Re: partitioning code reorganization

2018-04-14 Thread Amit Langote
On Sat, Apr 14, 2018 at 11:48 PM, Amit Langote wrote: > Hi. > > Thanks for taking care of few things I left like those PartitionKey > accessors in rel.h. Forgot to mention -- there are some files that still include catalog/partition.h but no longer need to. Find a delta patch attached that appli

Re: partitioning code reorganization

2018-04-14 Thread Tom Lane
Alvaro Herrera writes: > The one thing I don't like about this is having put > PartitionRangeDatumKind in partdefs.h, which forces us to #include that > file in parsenodes.h. I had to do this in order to avoid #including > parsenodes.h in partbounds.h. Now maybe that is not so bad, since that >

Re: partitioning code reorganization

2018-04-14 Thread Amit Langote
Hi. Thanks for taking care of few things I left like those PartitionKey accessors in rel.h. On Sat, Apr 14, 2018 at 8:51 PM, Alvaro Herrera wrote: > Here's a final version. > > The one thing I don't like about this is having put > PartitionRangeDatumKind in partdefs.h, which forces us to #includ

Re: partitioning code reorganization

2018-04-13 Thread Alvaro Herrera
Further thought: compute_hash_value and satisfies_hash_partition both belong in partbounds.c. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services