Re: parens cleanup

2020-01-30 Thread Alvaro Herrera
Thanks both for looking! I have pushed those, removing the zic.c changes. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: parens cleanup

2020-01-29 Thread Michael Paquier
On Wed, Jan 29, 2020 at 04:47:19PM -0500, Tom Lane wrote: > Alvaro Herrera writes: >> 0002 removes newlines immediately following parens. These were >> previously useful because pgindent would move arguments further to the >> left so that the line would fit under 80 chars. However, pgindent no >

Re: parens cleanup

2020-01-29 Thread Tom Lane
Alvaro Herrera writes: > Some ereport calls have excess sets of parentheses. patch 0001 removes > the ones I found in a very quick grep. +1 ... kind of looks like somebody got this wrong long ago, and then various people copied-and-pasted from a bad example. > 0002 removes newlines immediately

parens cleanup

2020-01-29 Thread Alvaro Herrera
Some ereport calls have excess sets of parentheses. patch 0001 removes the ones I found in a very quick grep. 0002 removes newlines immediately following parens. These were previously useful because pgindent would move arguments further to the left so that the line would fit under 80 chars. How