Re: outdated comment in table_tuple_update definition

2025-02-10 Thread Ashutosh Bapat
On Fri, Feb 7, 2025 at 3:08 AM Daniel Gustafsson wrote: > > > On 6 Feb 2025, at 20:00, Sergei Kornilov wrote: > > > I found that the parameter type was changed by commit 19d8e23 (Ignore BRIN > > indexes when checking for HOT updates), but the comment was not updated. > > Looks like oversight. >

Re: outdated comment in table_tuple_update definition

2025-02-06 Thread Daniel Gustafsson
> On 6 Feb 2025, at 20:00, Sergei Kornilov wrote: > I found that the parameter type was changed by commit 19d8e23 (Ignore BRIN > indexes when checking for HOT updates), but the comment was not updated. > Looks like oversight. I agree with your analysis, unless objected to I'll apply the attach

outdated comment in table_tuple_update definition

2025-02-06 Thread Sergei Kornilov
Hello I noticed that the comment for the table_tuple_update function (src/include/access/tableam.h) describes the update_indexes parameter as boolean: * update_indexes - in success cases this is set to true if new index entries * are required for this tuple Although this param