On Wed, Nov 20, 2024 at 4:41 AM Andrey M. Borodin wrote:
> > On 15 Nov 2024, at 21:33, Peter Geoghegan wrote:
> > I propose this for the master branch only.
>
> The change seems correct to me: anyway cycle must be less than cycle of any
> future vacuum after promotion.
The cycles set in the pag
On Wed, Nov 20, 2024 at 1:32 AM Michael Paquier wrote:
> Perhaps this patch should also explain why this is better this way?
See the commit message, and my remarks to Andrey just now.
> This path does not manipulate btpo_level, for one.
Why would it do so? Changing the btree level would corrupt
> On 15 Nov 2024, at 21:33, Peter Geoghegan wrote:
>
> Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
> routine, to reset the target page's opaque->btpo_cycleid to 0. This
> makes the REDO routine match original execution, which seems like a
> good idea on consistency grounds.
On Fri, Nov 15, 2024 at 11:33:37AM -0500, Peter Geoghegan wrote:
> Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
> routine, to reset the target page's opaque->btpo_cycleid to 0. This
> makes the REDO routine match original execution, which seems like a
> good idea on consistency gr
Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
routine, to reset the target page's opaque->btpo_cycleid to 0. This
makes the REDO routine match original execution, which seems like a
good idea on consistency grounds.
I propose this for the master branch only.
--
Peter Geoghegan
