Re: more unconstify use

2019-02-14 Thread Peter Eisentraut
On 13/02/2019 19:51, Mark Dilger wrote: > Peter, so sorry I did not review this patch before you committed. There > are a few places where you unconstify the argument to a function where > changing the function to take const seems better to me. I argued for > something similar in 2016, One can c

Re: more unconstify use

2019-02-13 Thread Mark Dilger
> On Feb 7, 2019, at 12:14 AM, Peter Eisentraut > wrote: > > Here is a patch that makes more use of unconstify() by replacing casts > whose only purpose is to cast away const. Also a preliminary patch to > remove casts that were useless to begin with. > > -- > Peter Eisentraut

Re: more unconstify use

2019-02-13 Thread Peter Eisentraut
On 07/02/2019 09:14, Peter Eisentraut wrote: > Here is a patch that makes more use of unconstify() by replacing casts > whose only purpose is to cast away const. Also a preliminary patch to > remove casts that were useless to begin with. committed -- Peter Eisentraut http://www.2nd

more unconstify use

2019-02-07 Thread Peter Eisentraut
85a967b2740cc93cfb7a7b076 -- 2.20.1 From 8dc004406f742dce9c76d0b922f45fdfda174ea3 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 29 Jan 2019 01:16:24 +0100 Subject: [PATCH v1 2/5] More unconstify use Replace casts whose only purpose is to cast away const with the unconstify() mac