Re: modify error report in mdwrite/mdextend

2021-10-18 Thread Alvaro Herrera
On 2021-Oct-18, Bharath Rupireddy wrote: > On Mon, Oct 18, 2021 at 1:45 PM 蔡梦娟(玊于) wrote: > > Does this match your previous expectations? Hope to get your reply. > > The control from the below ereport(ERROR, doesn't reach the short > write error part. IMO, the existing way does no harm, it is a

Re: modify error report in mdwrite/mdextend

2021-10-18 Thread Bharath Rupireddy
On Mon, Oct 18, 2021 at 1:45 PM 蔡梦娟(玊于) wrote: > > > Hi, all > I noticed that the "else" is missing during the error report after > FileWrite() of mdwrite()/mdextend(), short write error is supposed to be > reported when written bytes is not less than 0. > I modified it in the attached patch: >

modify error report in mdwrite/mdextend

2021-10-18 Thread 蔡梦娟(玊于)
Hi, all I noticed that the "else" is missing during the error report after FileWrite() of mdwrite()/mdextend(), short write error is supposed to be reported when written bytes is not less than 0. I modified it in the attached patch: diff --git a/src/backend/storage/smgr/md.c b/src/backend/storag