Re: missing support of named convention for procedures

2018-04-14 Thread Pavel Stehule
2018-04-14 15:58 GMT+02:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 3/22/18 10:19, Pavel Stehule wrote: > > attached patch should to fix it > > Committed. > Thank you Pavel > > I had to make a small tweak to make INOUT + DEFAULT parameters work in > PL/pgSQL. > > -- > Peter Ei

Re: missing support of named convention for procedures

2018-04-14 Thread Peter Eisentraut
On 3/22/18 10:19, Pavel Stehule wrote: > attached patch should to fix it Committed. I had to make a small tweak to make INOUT + DEFAULT parameters work in PL/pgSQL. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: missing support of named convention for procedures

2018-04-11 Thread Peter Eisentraut
On 4/11/18 12:06, Andres Freund wrote: > On 2018-03-22 15:19:12 +0100, Pavel Stehule wrote: >> attached patch should to fix it > > This is still broken, and has been an open item for a bit. Peter, Could > you check whether Pavel's fix resolves the issue for you? Yes, I will work on this. -- Pet

Re: missing support of named convention for procedures

2018-04-11 Thread Andres Freund
Hi Peter, Pavel, On 2018-03-22 15:19:12 +0100, Pavel Stehule wrote: > attached patch should to fix it This is still broken, and has been an open item for a bit. Peter, Could you check whether Pavel's fix resolves the issue for you? Regards, Andres

Re: missing support of named convention for procedures

2018-03-22 Thread Pavel Stehule
Hi 2018-03-21 8:18 GMT+01:00 Pavel Stehule : > > > 2018-03-20 17:31 GMT+01:00 Peter Eisentraut com>: > >> On 3/16/18 06:29, Pavel Stehule wrote: >> > attached patch fixes it >> >> The fix doesn't seem to work for LANGUAGE SQL procedures. For example: >> >> CREATE PROCEDURE ptest5(a int, b int D

Re: missing support of named convention for procedures

2018-03-21 Thread Pavel Stehule
2018-03-20 17:31 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 3/16/18 06:29, Pavel Stehule wrote: > > attached patch fixes it > > The fix doesn't seem to work for LANGUAGE SQL procedures. For example: > > CREATE PROCEDURE ptest5(a int, b int DEFAULT 0) > LANGUAGE SQL > AS

Re: missing support of named convention for procedures

2018-03-20 Thread Peter Eisentraut
On 3/16/18 06:29, Pavel Stehule wrote: > attached patch fixes it The fix doesn't seem to work for LANGUAGE SQL procedures. For example: CREATE PROCEDURE ptest5(a int, b int DEFAULT 0) LANGUAGE SQL AS $$ INSERT INTO cp_test VALUES (a, 'foo'); INSERT INTO cp_test VALUES (b, 'bar'); $$; CALL ptest5

Re: missing support of named convention for procedures

2018-03-16 Thread Pavel Stehule
2018-03-16 11:29 GMT+01:00 Pavel Stehule : > > > 2018-03-16 8:43 GMT+01:00 Pavel Stehule : > >> >> >> 2018-03-15 22:13 GMT+01:00 Pavel Stehule : >> >>> Hi >>> >>> create or replace procedure proc2(in a int, in b int) >>> as $$ >>> begin >>> a := a * 10; >>> b := b * 10; >>> end; >>> $$ languag

Re: missing support of named convention for procedures

2018-03-16 Thread Pavel Stehule
2018-03-16 8:43 GMT+01:00 Pavel Stehule : > > > 2018-03-15 22:13 GMT+01:00 Pavel Stehule : > >> Hi >> >> create or replace procedure proc2(in a int, in b int) >> as $$ >> begin >> a := a * 10; >> b := b * 10; >> end; >> $$ language plpgsql; >> >> postgres=# call proc2(a => 10,b => 20); >> ERRO

Re: missing support of named convention for procedures

2018-03-16 Thread Pavel Stehule
2018-03-15 22:13 GMT+01:00 Pavel Stehule : > Hi > > create or replace procedure proc2(in a int, in b int) > as $$ > begin > a := a * 10; > b := b * 10; > end; > $$ language plpgsql; > > postgres=# call proc2(a => 10,b => 20); > ERROR: XX000: unrecognized node type: 107 > LOCATION: ExecInitEx

missing support of named convention for procedures

2018-03-15 Thread Pavel Stehule
Hi create or replace procedure proc2(in a int, in b int) as $$ begin a := a * 10; b := b * 10; end; $$ language plpgsql; postgres=# call proc2(a => 10,b => 20); ERROR: XX000: unrecognized node type: 107 LOCATION: ExecInitExprRec, execExpr.c:2114 Regards Pavel