Re: minor fix for acquire_inherited_sample_rows

2018-05-01 Thread Amit Langote
On 2018/04/27 22:42, Ashutosh Bapat wrote: > On Thu, Apr 26, 2018 at 7:08 PM, Amit Langote wrote: >> On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat >> wrote: >>> On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: +1. I think we're really abusing equalTupleDescs() for purposes for wh

Re: minor fix for acquire_inherited_sample_rows

2018-04-27 Thread Ashutosh Bapat
On Thu, Apr 26, 2018 at 7:08 PM, Amit Langote wrote: > On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat > wrote: >> On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: >>> +1. I think we're really abusing equalTupleDescs() for purposes for >>> which it was not invented. Instead of changing it,

Re: minor fix for acquire_inherited_sample_rows

2018-04-26 Thread Alvaro Herrera
Amit Langote wrote: > On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat > wrote: > > On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: > >> +1. I think we're really abusing equalTupleDescs() for purposes for > >> which it was not invented. Instead of changing it, let's invent a new > >> functio

Re: minor fix for acquire_inherited_sample_rows

2018-04-26 Thread Amit Langote
On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat wrote: > On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: >> +1. I think we're really abusing equalTupleDescs() for purposes for >> which it was not invented. Instead of changing it, let's invent a new >> function that tests for the thing parti

Re: minor fix for acquire_inherited_sample_rows

2018-04-26 Thread Ashutosh Bapat
On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: > On Tue, Apr 24, 2018 at 6:19 AM, Amit Langote > wrote: >> Given what equalTupleDescs was invented for (commit a152ebeec), reducing >> it down to what can be sensibly used for checking whether tuple conversion >> is needed between a parent and

Re: minor fix for acquire_inherited_sample_rows

2018-04-25 Thread Robert Haas
On Tue, Apr 24, 2018 at 6:19 AM, Amit Langote wrote: > Given what equalTupleDescs was invented for (commit a152ebeec), reducing > it down to what can be sensibly used for checking whether tuple conversion > is needed between a parent and child will, I'm afraid, make it useless for > its original p

Re: minor fix for acquire_inherited_sample_rows

2018-04-24 Thread Amit Langote
Hi. On 2018/04/24 0:16, Alvaro Herrera wrote: > Hello Amit > > Amit Langote wrote: > >> acquire_inherited_sample_rows() currently uses equalTupleDescs() being >> false as the condition for going to tupconv.c to determine whether tuple >> conversion is needed. But equalTupleDescs() will always r

Re: minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Amit Langote
On 2018/04/24 13:29, Ashutosh Bapat wrote: > On Mon, Apr 23, 2018 at 6:45 PM, Amit Langote wrote: >> On Mon, Apr 23, 2018 at 8:25 PM, Ashutosh Bapat wrote: >>> On Mon, Apr 23, 2018 at 3:44 PM, Amit Langote wrote: Hi. acquire_inherited_sample_rows() currently uses equalTupleDescs() b

Re: minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Ashutosh Bapat
On Mon, Apr 23, 2018 at 8:46 PM, Alvaro Herrera wrote: > Hello Amit > > Amit Langote wrote: > >> acquire_inherited_sample_rows() currently uses equalTupleDescs() being >> false as the condition for going to tupconv.c to determine whether tuple >> conversion is needed. But equalTupleDescs() will a

Re: minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Ashutosh Bapat
On Mon, Apr 23, 2018 at 6:45 PM, Amit Langote wrote: > Thanks for the review. > > On Mon, Apr 23, 2018 at 8:25 PM, Ashutosh Bapat > wrote: >> On Mon, Apr 23, 2018 at 3:44 PM, Amit Langote >> wrote: >>> Hi. >>> >>> acquire_inherited_sample_rows() currently uses equalTupleDescs() being >>> false a

Re: minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Alvaro Herrera
Hello Amit Amit Langote wrote: > acquire_inherited_sample_rows() currently uses equalTupleDescs() being > false as the condition for going to tupconv.c to determine whether tuple > conversion is needed. But equalTupleDescs() will always return false if > it's passed TupleDesc's of two different

Re: minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Amit Langote
Thanks for the review. On Mon, Apr 23, 2018 at 8:25 PM, Ashutosh Bapat wrote: > On Mon, Apr 23, 2018 at 3:44 PM, Amit Langote > wrote: >> Hi. >> >> acquire_inherited_sample_rows() currently uses equalTupleDescs() being >> false as the condition for going to tupconv.c to determine whether tuple >

Re: minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Ashutosh Bapat
On Mon, Apr 23, 2018 at 3:44 PM, Amit Langote wrote: > Hi. > > acquire_inherited_sample_rows() currently uses equalTupleDescs() being > false as the condition for going to tupconv.c to determine whether tuple > conversion is needed. But equalTupleDescs() will always return false if > it's passed

minor fix for acquire_inherited_sample_rows

2018-04-23 Thread Amit Langote
Hi. acquire_inherited_sample_rows() currently uses equalTupleDescs() being false as the condition for going to tupconv.c to determine whether tuple conversion is needed. But equalTupleDescs() will always return false if it's passed TupleDesc's of two different tables, which is the most common cas