Re: meson missing test dependencies

2025-02-04 Thread Andres Freund
Hi, I pushed these changes as part of https://postgr.es/m/fucdlk6bgvrz6vb6ruscxa5xof5w2c3voxoqontl7oasf4idxl%40uyljndimefct Greetings, Andres Freund

Re: meson missing test dependencies

2024-12-09 Thread Andres Freund
Hi, On 2024-12-09 16:06:18 +0100, Peter Eisentraut wrote: > On 07.12.24 21:45, Andres Freund wrote: > > If a test target does not have ay dependency 'meson test' treats it has > > having > > a dependency on the project default test. Which in turn currently includes > > everything that will be ins

Re: meson missing test dependencies

2024-12-09 Thread Peter Eisentraut
On 07.12.24 21:45, Andres Freund wrote: If a test target does not have ay dependency 'meson test' treats it has having a dependency on the project default test. Which in turn currently includes everything that will be installed, i.e. everything that tmp_install might need. But that's not somethin

Re: meson missing test dependencies

2024-12-07 Thread Andres Freund
Hi, On 2024-12-06 18:54:25 +0100, Peter Eisentraut wrote: > On 05.12.24 21:10, Andres Freund wrote: > > On 2024-12-05 20:08:24 +0100, Peter Eisentraut wrote: > > > On 03.12.24 17:01, Andres Freund wrote: > > > > On 2024-12-02 11:10:56 +0100, Peter Eisentraut wrote: > > > > That's unfortunately a v

Re: meson missing test dependencies

2024-12-06 Thread Peter Eisentraut
On 05.12.24 21:10, Andres Freund wrote: Hi, On 2024-12-05 20:08:24 +0100, Peter Eisentraut wrote: On 03.12.24 17:01, Andres Freund wrote: On 2024-12-02 11:10:56 +0100, Peter Eisentraut wrote: That's unfortunately a very partial fix - because we insist on tests being run against a temporary ins

Re: meson missing test dependencies

2024-12-05 Thread Andres Freund
Hi, On 2024-12-05 20:08:24 +0100, Peter Eisentraut wrote: > On 03.12.24 17:01, Andres Freund wrote: > > On 2024-12-02 11:10:56 +0100, Peter Eisentraut wrote: > > That's unfortunately a very partial fix - because we insist on tests being > > run > > against a temporary install, we don't just need

Re: meson missing test dependencies

2024-12-05 Thread Peter Eisentraut
On 03.12.24 17:01, Andres Freund wrote: Hi, On 2024-12-02 11:10:56 +0100, Peter Eisentraut wrote: I have noticed that under meson many tests don't have dependencies on the build artifacts that they are testing. As an example among many, if you make a source code change in contrib/cube/cube.c (

Re: meson missing test dependencies

2024-12-03 Thread Andres Freund
Hi, On 2024-12-02 11:10:56 +0100, Peter Eisentraut wrote: > I have noticed that under meson many tests don't have dependencies on the > build artifacts that they are testing. As an example among many, if you > make a source code change in contrib/cube/cube.c (see patch 0001 for a demo) > and then

Re: meson missing test dependencies

2024-12-03 Thread Nazir Bilal Yavuz
Hi, On Tue, 3 Dec 2024 at 04:05, Michael Paquier wrote: > > On Mon, Dec 02, 2024 at 01:50:57PM +0300, Nazir Bilal Yavuz wrote: > > On Mon, 2 Dec 2024 at 13:11, Peter Eisentraut wrote: > >> Is there any reason this was not done yet? > > > > This looks useful. I am not sure why this was not done b

Re: meson missing test dependencies

2024-12-03 Thread Nazir Bilal Yavuz
Hi, On Mon, 2 Dec 2024 at 22:27, Peter Eisentraut wrote: > > On 02.12.24 11:50, Nazir Bilal Yavuz wrote: > > I applied your patches and the cube example worked. But when I edited > > 'test_json_parser_perf.c' and 'test_json_parser_incremental.c', meson > > did not rebuild. I used the 'meson test

Re: meson missing test dependencies

2024-12-02 Thread Michael Paquier
On Mon, Dec 02, 2024 at 01:50:57PM +0300, Nazir Bilal Yavuz wrote: > On Mon, 2 Dec 2024 at 13:11, Peter Eisentraut wrote: >> Is there any reason this was not done yet? > > This looks useful. I am not sure why this was not done before. Do you think that it would be possible to automate the additi

Re: meson missing test dependencies

2024-12-02 Thread Peter Eisentraut
On 02.12.24 11:50, Nazir Bilal Yavuz wrote: I applied your patches and the cube example worked. But when I edited 'test_json_parser_perf.c' and 'test_json_parser_incremental.c', meson did not rebuild. I used the 'meson test -C build --suite setup --suite test_json_parser' command to test test_jso

Re: meson missing test dependencies

2024-12-02 Thread Nazir Bilal Yavuz
Hi, On Mon, 2 Dec 2024 at 13:11, Peter Eisentraut wrote: > > I have noticed that under meson many tests don't have dependencies on > the build artifacts that they are testing. As an example among many, if > you make a source code change in contrib/cube/cube.c (see patch 0001 for > a demo) and th

meson missing test dependencies

2024-12-02 Thread Peter Eisentraut
I have noticed that under meson many tests don't have dependencies on the build artifacts that they are testing. As an example among many, if you make a source code change in contrib/cube/cube.c (see patch 0001 for a demo) and then run make -C contrib/cube check the test run will reflect