Re: meson and check-tests

2025-03-22 Thread Rustam ALLAKOV
Hi, please note, same file `/src/tools/testwrap` on the same line number is being changed in this patch [1] in the same commitfest. [1] https://commitfest.postgresql.org/patch/5602/ Regards, Rustam Allakov

Re: meson and check-tests

2025-01-26 Thread Ashutosh Bapat
On Mon, Nov 25, 2024 at 7:06 PM Nazir Bilal Yavuz wrote: > > Hi, > > On Mon, 25 Nov 2024 at 16:19, Ashutosh Bapat > wrote: > > > > On Mon, Nov 25, 2024 at 6:47 PM Ashutosh Bapat > > wrote: > > > > > > > > For patch 2, it will be good to introduce expanded functionality to > > > make as well. But

Re: meson and check-tests

2024-11-25 Thread Nazir Bilal Yavuz
Hi, On Mon, 25 Nov 2024 at 16:19, Ashutosh Bapat wrote: > > On Mon, Nov 25, 2024 at 6:47 PM Ashutosh Bapat > wrote: > > > > > For patch 2, it will be good to introduce expanded functionality to > > make as well. But patch 1 is ready for the committer. So marked > > accordingly. > > > > Didn't fi

Re: meson and check-tests

2024-11-25 Thread Ashutosh Bapat
On Tue, Nov 19, 2024 at 6:43 PM Nazir Bilal Yavuz wrote: > > Hi, > > Thanks for checking it! > > On Tue, 19 Nov 2024 at 15:19, Ashutosh Bapat > wrote: > > > > On Thu, Oct 31, 2024 at 11:28 PM Nazir Bilal Yavuz > > wrote: > > > > > > Yes, that is exactly why we have both '--schedule' and '--test

Re: meson and check-tests

2024-11-25 Thread Ashutosh Bapat
On Mon, Nov 25, 2024 at 6:47 PM Ashutosh Bapat wrote: > > For patch 2, it will be good to introduce expanded functionality to > make as well. But patch 1 is ready for the committer. So marked > accordingly. > Didn't find a CF entry for this. Please create and update. -- Best Wishes, Ashutosh

Re: meson and check-tests

2024-11-20 Thread Nazir Bilal Yavuz
Hi, On Tue, 12 Nov 2024 at 18:13, jian he wrote: > > also played around with v5-0002, works fine. > overall, v5-0001 and v5-0002 works as i expected. Thanks for checking it! -- Regards, Nazir Bilal Yavuz Microsoft

Re: meson and check-tests

2024-11-19 Thread Nazir Bilal Yavuz
Hi, Thanks for checking it! On Tue, 19 Nov 2024 at 15:19, Ashutosh Bapat wrote: > > On Thu, Oct 31, 2024 at 11:28 PM Nazir Bilal Yavuz wrote: > > > > Yes, that is exactly why we have both '--schedule' and '--tests' > > flags. Also, a comment is added to clarify this. > > The comment is useful i

Re: meson and check-tests

2024-11-19 Thread Ashutosh Bapat
On Thu, Oct 31, 2024 at 11:28 PM Nazir Bilal Yavuz wrote: > > On Fri, 4 Oct 2024 at 18:40, Ashutosh Bapat > wrote: > > --schedule or the test selection becomes part of the test command > > itself in the current master. By passing it as an argument, in these > > patches, we are allowing those to b

Re: meson and check-tests

2024-11-12 Thread jian he
On Mon, Nov 11, 2024 at 4:14 PM Nazir Bilal Yavuz wrote: > > Hi, > > Thanks for the feedback! > > On Mon, 11 Nov 2024 at 06:34, jian he wrote: > > > > hi. > > Actually, there is a difference compared to make. > > make works fine with many whitespaces. but meson you can only have one > > whitespac

Re: meson and check-tests

2024-11-11 Thread Nazir Bilal Yavuz
Hi, Thanks for the feedback! On Mon, 11 Nov 2024 at 06:34, jian he wrote: > > hi. > Actually, there is a difference compared to make. > make works fine with many whitespaces. but meson you can only have one > whitespace. > > meson test -C $BUILD7 --num-processes 20 --suite setup --verbose > expo

Re: meson and check-tests

2024-11-10 Thread jian he
hi. Actually, there is a difference compared to make. make works fine with many whitespaces. but meson you can only have one whitespace. meson test -C $BUILD7 --num-processes 20 --suite setup --verbose export TESTS="test_setup boolean char" meson test -C $BUILD7 --suite regress --

Re: meson and check-tests

2024-10-31 Thread Nazir Bilal Yavuz
Hi Ashutosh and Jian, Sorry for the late reply and thanks for the feedback! On Fri, 4 Oct 2024 at 16:13, jian he wrote: > > v3, 0001 documentation: > We can at least write something on > https://wiki.postgresql.org/wiki/Meson about this feature. I agree. It seems that I need to apply for an edi

Re: meson and check-tests

2024-10-04 Thread Ashutosh Bapat
Hi Nazir, On Thu, Sep 26, 2024 at 4:14 PM Nazir Bilal Yavuz wrote: > > > > Let's split the patch into two 1. supporting TESTS in meson only for > > regress/regress, 2. extending that support to other suites. The first > > patch will bring meson inline with make as far as running a subset of > > r

Re: meson and check-tests

2024-10-04 Thread Ashutosh Bapat
On Fri, Oct 4, 2024 at 6:43 PM jian he wrote: > > v3, 0001 documentation: > We can at least write something on > https://wiki.postgresql.org/wiki/Meson about this feature. TESTS and make check-tests are both not documented under make. I don't know the reason. IMO we don't have to document it in m

Re: meson and check-tests

2024-10-04 Thread jian he
v3, 0001 documentation: We can at least write something on https://wiki.postgresql.org/wiki/Meson about this feature. TESTS='check check_btree' meson test amcheck/regress --verbose works, but I feel like there is a discoverability issue . TESTS='check check_btree' meson test amcheck/regress --li

Re: meson and check-tests

2024-09-26 Thread Nazir Bilal Yavuz
Hi, On Thu, 26 Sept 2024 at 08:45, Ashutosh Bapat wrote: > > On Wed, Sep 25, 2024 at 8:24 PM Nazir Bilal Yavuz wrote: > > > > Additionally, the patch I shared earlier was only for regress/regress > > tests. From what I understand from here [1], only regress/regress > > tests support 'make check-

Re: meson and check-tests

2024-09-25 Thread Ashutosh Bapat
On Wed, Sep 25, 2024 at 8:24 PM Nazir Bilal Yavuz wrote: > > Hi, > > Thanks for looking into this! > > On Wed, 25 Sept 2024 at 13:27, Ashutosh Bapat > wrote: > > > > On Mon, Sep 23, 2024 at 2:16 PM Nazir Bilal Yavuz > > wrote: > > > > > > On Sat, 21 Sept 2024 at 09:01, jian he > > > wrote: >

Re: meson and check-tests

2024-09-25 Thread Nazir Bilal Yavuz
Hi, Thanks for looking into this! On Wed, 25 Sept 2024 at 13:27, Ashutosh Bapat wrote: > > On Mon, Sep 23, 2024 at 2:16 PM Nazir Bilal Yavuz wrote: > > > > On Sat, 21 Sept 2024 at 09:01, jian he wrote: > > > > > > so > > > TESTS="copy jsonb stats_ext" meson test --suite regress > > > will fail

Re: meson and check-tests

2024-09-25 Thread Ashutosh Bapat
On Mon, Sep 23, 2024 at 2:16 PM Nazir Bilal Yavuz wrote: > > Hi, > > On Sat, 21 Sept 2024 at 09:01, jian he wrote: > > > > hi. Thanks for your work! > > Thank you for looking into this! > > > I do find some issues. > > > > > > TESTS="copy jsonb jsonb" meson test --suite regress > > one will fail.

Re: meson and check-tests

2024-09-23 Thread Nazir Bilal Yavuz
Hi, On Mon, 23 Sept 2024 at 11:46, Nazir Bilal Yavuz wrote: > On Sat, 21 Sept 2024 at 09:01, jian he wrote: > > in [1] you mentioned "setup", but that "setup" is more or less like > > "meson test --suite setup --suite regress" > > but originally, I thought was about "src/test/regress/sql/test_s

Re: meson and check-tests

2024-09-23 Thread Nazir Bilal Yavuz
Hi, On Sat, 21 Sept 2024 at 09:01, jian he wrote: > > hi. Thanks for your work! Thank you for looking into this! > I do find some issues. > > > TESTS="copy jsonb jsonb" meson test --suite regress > one will fail. not sure this is expected? Yes, that is expected. > in [1] you mentioned "setup"

Re: meson and check-tests

2024-09-20 Thread jian he
On Fri, Sep 20, 2024 at 6:25 PM Nazir Bilal Yavuz wrote: > > Hi, > > I’ve been working on a patch and wanted to share my approach, which > might be helpful for others. The patch removes the '--schedule' and > '${schedule_file}' options from the regress/regress test command when > the TESTS environ

Re: meson and check-tests

2024-09-20 Thread Nazir Bilal Yavuz
Hi, I’ve been working on a patch and wanted to share my approach, which might be helpful for others. The patch removes the '--schedule' and '${schedule_file}' options from the regress/regress test command when the TESTS environment variable is set. Instead, it appends the TESTS variable to the end

Re: meson and check-tests

2024-09-04 Thread jian he
On Wed, Jun 5, 2024 at 7:26 PM Ashutosh Bapat wrote: > > > > On Mon, Jun 3, 2024 at 10:04 PM Tristan Partin wrote: >> >> On Sun Jun 2, 2024 at 12:25 AM CDT, Tom Lane wrote: >> > "Tristan Partin" writes: >> > > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: >> > >> We talked this off-

Re: meson and check-tests

2024-06-05 Thread Ashutosh Bapat
On Mon, Jun 3, 2024 at 10:04 PM Tristan Partin wrote: > On Sun Jun 2, 2024 at 12:25 AM CDT, Tom Lane wrote: > > "Tristan Partin" writes: > > > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: > > >> We talked this off-list at the conference. It seems we have to somehow > > >> avoid pas

Re: meson and check-tests

2024-06-03 Thread Tristan Partin
On Sun Jun 2, 2024 at 12:25 AM CDT, Tom Lane wrote: "Tristan Partin" writes: > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: >> We talked this off-list at the conference. It seems we have to somehow >> avoid passing pg_regress --schedule argument and instead pass the list of >> test

Re: meson and check-tests

2024-06-02 Thread Nazir Bilal Yavuz
Hi, On Sun, 2 Jun 2024 at 07:06, jian he wrote: > > On Sun, Jun 2, 2024 at 4:48 AM Tristan Partin wrote: > > > > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: > > > Hi Tristan, > > > Using make I can run only selected tests under src/test/regress using > > > TESTS=... make check-tes

Re: meson and check-tests

2024-06-02 Thread Andrew Dunstan
On 2024-06-02 Su 01:25, Tom Lane wrote: "Tristan Partin" writes: On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: We talked this off-list at the conference. It seems we have to somehow avoid passing pg_regress --schedule argument and instead pass the list of tests. Any idea how to

Re: meson and check-tests

2024-06-01 Thread Tom Lane
"Tristan Partin" writes: > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: >> We talked this off-list at the conference. It seems we have to somehow >> avoid passing pg_regress --schedule argument and instead pass the list of >> tests. Any idea how to do that? > I think there are 2 sol

Re: meson and check-tests

2024-06-01 Thread jian he
On Sun, Jun 2, 2024 at 4:48 AM Tristan Partin wrote: > > On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: > > Hi Tristan, > > Using make I can run only selected tests under src/test/regress using > > TESTS=... make check-tests. I didn't find any way to do that with meson. > > meson test

Re: meson and check-tests

2024-06-01 Thread Tristan Partin
On Fri May 31, 2024 at 12:02 PM CDT, Ashutosh Bapat wrote: Hi Tristan, Using make I can run only selected tests under src/test/regress using TESTS=... make check-tests. I didn't find any way to do that with meson. meson test --suite regress runs all the regression tests. We talked this off-list

meson and check-tests

2024-05-31 Thread Ashutosh Bapat
Hi Tristan, Using make I can run only selected tests under src/test/regress using TESTS=... make check-tests. I didn't find any way to do that with meson. meson test --suite regress runs all the regression tests. We talked this off-list at the conference. It seems we have to somehow avoid passing