Hi,
I was looking at older threads and found that. There were failures
when rebasing v1-uuid patch to master so I updated it and also added
documentation. I attached the v2 of the patch. I am sending v2 patch
to this thread but should I create a new thread for uuid patch?
Regards,
Nazir Bilal Yav
On 22.03.23 11:16, Nazir Bilal Yavuz wrote:
Hi,
On Wed, 15 Mar 2023 at 11:12, Peter Eisentraut
wrote:
On 14.03.23 15:07, Nazir Bilal Yavuz wrote:
I think the uuid side of this is making this way too complicated. I'm
content leaving this as a manual option for now.
There is much more value
Hi,
On Wed, 15 Mar 2023 at 11:12, Peter Eisentraut
wrote:
>
> On 14.03.23 15:07, Nazir Bilal Yavuz wrote:
> >> I think the uuid side of this is making this way too complicated. I'm
> >> content leaving this as a manual option for now.
> >>
> >> There is much more value in making the ssl option w
On 14.03.23 15:07, Nazir Bilal Yavuz wrote:
I think the uuid side of this is making this way too complicated. I'm
content leaving this as a manual option for now.
There is much more value in making the ssl option work automatically.
So I would welcome a patch that just makes -Dssl=auto work smo
Hi,
On Wed, 22 Feb 2023 at 12:14, Peter Eisentraut
wrote:
>
> On 21.02.23 17:32, Nazir Bilal Yavuz wrote:
> >>> I like the second approach, with a 'uuid' feature option. As you wrote
> >>> earlier, adding an 'auto' choice to a combo option doesn't work fully
> >>> like a
> >>> real feature opti
On Mon, Mar 13, 2023 at 02:45:29PM -0700, Andres Freund wrote:
> Pushed the patch.
Thanks for the prompt fix.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hi,
On 2023-03-13 23:46:41 +0300, Nazir Bilal Yavuz wrote:
> Thanks for the patch, I understand the problem now and your patch fixes this.
Pushed the patch.
Greetings,
Andres Freund
Hi,
On Mon, 13 Mar 2023 at 23:14, Andres Freund wrote:
>
> Hi,
>
> On 2023-03-13 21:57:22 +0300, Nazir Bilal Yavuz wrote:
> > On Mon, 13 Mar 2023 at 21:04, Nathan Bossart
> > wrote:
> > >
> > > On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentraut wrote:
> > > > I have committed it like th
On Mon, Mar 13, 2023 at 01:13:31PM -0700, Andres Freund wrote:
> On 2023-03-13 11:04:32 -0700, Nathan Bossart wrote:
>> I noticed that after 6a30027, if you don't have the OpenSSL headers
>> installed, 'meson setup' will fail:
>>
>> meson.build:1195:4: ERROR: C header 'openssl/ssl.h' not foun
Hi,
On 2023-03-13 21:57:22 +0300, Nazir Bilal Yavuz wrote:
> On Mon, 13 Mar 2023 at 21:04, Nathan Bossart wrote:
> >
> > On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentraut wrote:
> > > I have committed it like this.
> >
> > I noticed that after 6a30027, if you don't have the OpenSSL heade
Hi,
On 2023-03-13 11:04:32 -0700, Nathan Bossart wrote:
> On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentraut wrote:
> > I have committed it like this.
>
> I noticed that after 6a30027, if you don't have the OpenSSL headers
> installed, 'meson setup' will fail:
>
> meson.build:1195:
On Mon, Mar 13, 2023 at 09:57:22PM +0300, Nazir Bilal Yavuz wrote:
> On Mon, 13 Mar 2023 at 21:04, Nathan Bossart wrote:
>> Shouldn't "auto" cause Postgres to be built without OpenSSL if the required
>> headers are not present?
>
> Yes, I tested again and it is working as expected on my end. It
>
Hi,
On Mon, 13 Mar 2023 at 21:04, Nathan Bossart wrote:
>
> On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentraut wrote:
> > I have committed it like this.
>
> I noticed that after 6a30027, if you don't have the OpenSSL headers
> installed, 'meson setup' will fail:
>
> meson.build:11
On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentraut wrote:
> I have committed it like this.
I noticed that after 6a30027, if you don't have the OpenSSL headers
installed, 'meson setup' will fail:
meson.build:1195:4: ERROR: C header 'openssl/ssl.h' not found
Shouldn't "auto" cause
On 09.03.23 14:54, Daniel Gustafsson wrote:
On 9 Mar 2023, at 14:45, Peter Eisentraut
wrote:
How about we just hardcode "openssl" here instead? We could build that array
dynamically, of course, but maybe we leave that until we actually have a need?
At least for 16 keeping it hardcoded is
Hi,
On Thu, 9 Mar 2023 at 17:18, Peter Eisentraut
wrote:
>
> On 09.03.23 15:12, Nazir Bilal Yavuz wrote:
> > Hi,
> >
> > On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson wrote:
> >>
> >>> On 9 Mar 2023, at 14:45, Peter Eisentraut
> >>> wrote:
> >>
> >>> How about we just hardcode "openssl" here
On 09.03.23 15:12, Nazir Bilal Yavuz wrote:
Hi,
On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson wrote:
On 9 Mar 2023, at 14:45, Peter Eisentraut
wrote:
How about we just hardcode "openssl" here instead? We could build that array
dynamically, of course, but maybe we leave that until we
> On 9 Mar 2023, at 15:12, Nazir Bilal Yavuz wrote:
>
> Hi,
>
> On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson wrote:
>>
>>> On 9 Mar 2023, at 14:45, Peter Eisentraut
>>> wrote:
>>
>>> How about we just hardcode "openssl" here instead? We could build that
>>> array dynamically, of course,
Hi,
On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson wrote:
>
> > On 9 Mar 2023, at 14:45, Peter Eisentraut
> > wrote:
>
> > How about we just hardcode "openssl" here instead? We could build that
> > array dynamically, of course, but maybe we leave that until we actually
> > have a need?
>
> A
> On 9 Mar 2023, at 14:45, Peter Eisentraut
> wrote:
> How about we just hardcode "openssl" here instead? We could build that array
> dynamically, of course, but maybe we leave that until we actually have a need?
At least for 16 keeping it hardcoded is an entirely safe bet so +1 for leaving
a
On 03.03.23 11:01, Nazir Bilal Yavuz wrote:
On Fri, 3 Mar 2023 at 12:16, Peter Eisentraut
wrote:
On 02.03.23 11:41, Nazir Bilal Yavuz wrote:
I am kind of confused. I added these checks for considering other SSL
implementations in the future, for this reason I have two nested if
checks. The to
Hi,
On Fri, 3 Mar 2023 at 12:16, Peter Eisentraut
wrote:
>
> On 02.03.23 11:41, Nazir Bilal Yavuz wrote:
> > I am kind of confused. I added these checks for considering other SSL
> > implementations in the future, for this reason I have two nested if
> > checks. The top one is for checking if we
On 02.03.23 11:41, Nazir Bilal Yavuz wrote:
I am kind of confused. I added these checks for considering other SSL
implementations in the future, for this reason I have two nested if
checks. The top one is for checking if we need to search an SSL
library and the nested one is for checking if we ne
Hi,
Thanks for the review.
On Wed, 1 Mar 2023 at 18:52, Peter Eisentraut
wrote:
>
> Maybe we can make some of the logic less nested. Right now there is
>
> if sslopt != 'none'
>
>if not ssl.found() and sslopt in ['auto', 'openssl']
>
> I think at that point, ssl.found() is never tr
On 24.02.23 14:01, Nazir Bilal Yavuz wrote:
Thanks for the feedback. I updated the ssl patch and if you like
changes, I can apply the same logic to uuid.
Maybe we can make some of the logic less nested. Right now there is
if sslopt != 'none'
if not ssl.found() and sslopt in ['auto'
Hi,
On Wed, 22 Feb 2023 at 12:14, Peter Eisentraut
wrote:
>
> On 21.02.23 17:32, Nazir Bilal Yavuz wrote:
> >>> I like the second approach, with a 'uuid' feature option. As you wrote
> >>> earlier, adding an 'auto' choice to a combo option doesn't work fully
> >>> like a
> >>> real feature opti
On 21.02.23 17:32, Nazir Bilal Yavuz wrote:
I like the second approach, with a 'uuid' feature option. As you wrote
earlier, adding an 'auto' choice to a combo option doesn't work fully like a
real feature option.
But we can make it behave exactly like one, by checking the auto_features
option.
Hi,
On Mon, 20 Feb 2023 at 22:42, Andres Freund wrote:
> On 2023-02-20 19:53:53 +0100, Peter Eisentraut wrote:
> > On 20.02.23 13:33, Nazir Bilal Yavuz wrote:
> > > I added SSL and UUID patches. UUID patch has two different fixes:
> > >
> > > 1 - v1-0002-meson-Refactor-UUID-option.patch: Adding '
Hi,
On 2023-02-20 19:53:53 +0100, Peter Eisentraut wrote:
> On 20.02.23 13:33, Nazir Bilal Yavuz wrote:
> > I added SSL and UUID patches. UUID patch has two different fixes:
> >
> > 1 - v1-0002-meson-Refactor-UUID-option.patch: Adding 'auto' choice to
> > 'uuid' combo option.
> >
> > 2 - v1-0002
> On 20 Feb 2023, at 19:53, Peter Eisentraut
> wrote:
> I would rename the ssl_type variable to ssl_library, so that if we ever
> expose that as an option, it would be consistent with uuid_library.
+1, ssl_library is a better name.
--
Daniel Gustafsson
Hi,
On Mon, 20 Feb 2023 at 21:53, Peter Eisentraut
wrote:
>
> But what does uuid_library=auto do? Which one does it pick? This is
> not a behavior we currently have, is it?
Yes, we didn't have that behavior before. It checks uuid libs by the
order of 'e2fs', 'bsd' and 'ossp'. It uses the first
On 20.02.23 13:33, Nazir Bilal Yavuz wrote:
I added SSL and UUID patches. UUID patch has two different fixes:
1 - v1-0002-meson-Refactor-UUID-option.patch: Adding 'auto' choice to
'uuid' combo option.
2 - v1-0002-meson-Refactor-UUID-option-with-uuid_library.patch: Making
'uuid' feature optio
Hi,
I added SSL and UUID patches. UUID patch has two different fixes:
1 - v1-0002-meson-Refactor-UUID-option.patch: Adding 'auto' choice to
'uuid' combo option.
2 - v1-0002-meson-Refactor-UUID-option-with-uuid_library.patch: Making
'uuid' feature option and adding new 'uuid_library' combo op
Hi,
On 2/8/23 19:23, Andres Freund wrote:
For the 'uuid' option, I'm not sure what the best way to address this would.
We could establish a search order of libraries that is used if no specific
one is set (similar to libreadline, libedit, in a way). So we'd have one
option 'uuid' that is of ty
Hi,
On 2023-02-08 11:45:05 +0100, Peter Eisentraut wrote:
> Most meson options (meson_options.txt) that enable an external dependency
> (e.g., icu, ldap) are of type 'feature'. Most of these have a default value
> of 'auto', which means they are pulled in automatically if found. Some have
> a de
Hi,
On 2/8/23 13:45, Peter Eisentraut wrote:
The problem is that these features now cannot be automatically enabled
and behave annoyingly different from other feature options.
Agreed.
For the 'ssl' option, we have deprecated the --with-openssl option in
configure and replaced it with --w
Most meson options (meson_options.txt) that enable an external
dependency (e.g., icu, ldap) are of type 'feature'. Most of these have
a default value of 'auto', which means they are pulled in automatically
if found. Some have a default value of 'disabled' for specific reasons
(e.g., selinux).
37 matches
Mail list logo
